Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fflas-ffpack: Drop liblapack dependency #39384

Merged
merged 1 commit into from Apr 23, 2018
Merged

fflas-ffpack: Drop liblapack dependency #39384

merged 1 commit into from Apr 23, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 23, 2018 •
edited

Motivation for this change

lapack doesn't build on aarch64 and is not needed for fflas-ffpack.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau force-pushed the fllas-ffpack-atlas branch 2 times, most recently from 73649a8 to 5d2671d Compare April 23, 2018 20:00
@timokau timokau mentioned this pull request Apr 23, 2018
Merged
8 tasks
@7c6f434c
Copy link
Member

@GrahamcOfBorg build fflas-ffpack

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fflas-ffpack

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fflas-ffpack

Partial log (click to expand)

 /nix/store/jy9knxp7nmw80jkf932axrs1b4p9k4hi-coreutils-8.29/bin/install -c -m 644 fflas-ffpack.pc '/nix/store/m9ymsjw251sj1920q3bkc7p0rm5821w5-fflas-ffpack-2.3.2/lib/pkgconfig'
make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m9ymsjw251sj1920q3bkc7p0rm5821w5-fflas-ffpack-2.3.2
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m9ymsjw251sj1920q3bkc7p0rm5821w5-fflas-ffpack-2.3.2/lib  /nix/store/m9ymsjw251sj1920q3bkc7p0rm5821w5-fflas-ffpack-2.3.2/bin
patching script interpreter paths in /nix/store/m9ymsjw251sj1920q3bkc7p0rm5821w5-fflas-ffpack-2.3.2
/nix/store/m9ymsjw251sj1920q3bkc7p0rm5821w5-fflas-ffpack-2.3.2/bin/fflas-ffpack-config: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/m9ymsjw251sj1920q3bkc7p0rm5821w5-fflas-ffpack-2.3.2...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: fflas-ffpack

Partial log (click to expand)

PASS: test-maxdelayeddim
g++ -DHAVE_CONFIG_H -I. -I..    -O2  -Wall -g  -I..  -I/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/include -fabi-version=6 -fopenmp -c -o test-solve.o test-solve.C
/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash ../libtool  --tag=CXX   --mode=link g++ -O2  -Wall -g  -I..  -I/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/include -fabi-version=6 -fopenmp   -o test-solve test-solve.o  -L/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib -lgivaro -lgmp -lgmpxx  -fopenmp -lopenblas
libtool: link: g++ -O2 -Wall -g -I.. -I/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/include -fabi-version=6 -fopenmp -o test-solve test-solve.o -fopenmp  -L/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib /nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib/libgivaro.so -lm /nix/store/8r6h7gzccqrd59rzdp7y7hgr388injyw-gmp-6.1.2/lib/libgmpxx.so /nix/store/8r6h7gzccqrd59rzdp7y7hgr388injyw-gmp-6.1.2/lib/libgmp.so /nix/store/07fzvxdh5q2hj27j5f6rxi8gr1pg7qac-gcc-7.3.0-lib/lib/../lib64/libstdc++.so -lopenblas -fopenmp -Wl,-rpath -Wl,/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib -Wl,-rpath -Wl,/nix/store/8r6h7gzccqrd59rzdp7y7hgr388injyw-gmp-6.1.2/lib -Wl,-rpath -Wl,/nix/store/07fzvxdh5q2hj27j5f6rxi8gr1pg7qac-gcc-7.3.0-lib/lib/../lib64 -Wl,-rpath -Wl,/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib -Wl,-rpath -Wl,/nix/store/8r6h7gzccqrd59rzdp7y7hgr388injyw-gmp-6.1.2/lib -Wl,-rpath -Wl,/nix/store/07fzvxdh5q2hj27j5f6rxi8gr1pg7qac-gcc-7.3.0-lib/lib/../lib64
PASS: test-solve
g++ -DHAVE_CONFIG_H -I. -I..    -O2  -Wall -g  -I..  -I/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/include -fabi-version=6 -fopenmp -c -o test-fgemv.o test-fgemv.C
/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash ../libtool  --tag=CXX   --mode=link g++ -O2  -Wall -g  -I..  -I/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/include -fabi-version=6 -fopenmp   -o test-fgemv test-fgemv.o  -L/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib -lgivaro -lgmp -lgmpxx  -fopenmp -lopenblas
libtool: link: g++ -O2 -Wall -g -I.. -I/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/include -fabi-version=6 -fopenmp -o test-fgemv test-fgemv.o -fopenmp  -L/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib /nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib/libgivaro.so -lm /nix/store/8r6h7gzccqrd59rzdp7y7hgr388injyw-gmp-6.1.2/lib/libgmpxx.so /nix/store/8r6h7gzccqrd59rzdp7y7hgr388injyw-gmp-6.1.2/lib/libgmp.so /nix/store/07fzvxdh5q2hj27j5f6rxi8gr1pg7qac-gcc-7.3.0-lib/lib/../lib64/libstdc++.so -lopenblas -fopenmp -Wl,-rpath -Wl,/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib -Wl,-rpath -Wl,/nix/store/8r6h7gzccqrd59rzdp7y7hgr388injyw-gmp-6.1.2/lib -Wl,-rpath -Wl,/nix/store/07fzvxdh5q2hj27j5f6rxi8gr1pg7qac-gcc-7.3.0-lib/lib/../lib64 -Wl,-rpath -Wl,/nix/store/qsvwqchnkvsfg9d0zs2xna8g63xy30ff-givaro-4.0.4/lib -Wl,-rpath -Wl,/nix/store/8r6h7gzccqrd59rzdp7y7hgr388injyw-gmp-6.1.2/lib -Wl,-rpath -Wl,/nix/store/07fzvxdh5q2hj27j5f6rxi8gr1pg7qac-gcc-7.3.0-lib/lib/../lib64
building of '/nix/store/3107lzq4mpd8iq8pb3vbcaq4c79lcnjq-fflas-ffpack-2.3.2.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/3107lzq4mpd8iq8pb3vbcaq4c79lcnjq-fflas-ffpack-2.3.2.drv' failed

@matthewbauer matthewbauer merged commit 50d410b into NixOS:master Apr 23, 2018
@timokau timokau deleted the fllas-ffpack-atlas branch April 23, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @7c6f434c @GrahamcOfBorg @matthewbauer