Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5.qtwebkit: Reduce log size to fix hydra build #40031

Merged
merged 1 commit into from May 6, 2018
Merged

qt5.qtwebkit: Reduce log size to fix hydra build #40031

merged 1 commit into from May 6, 2018

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented May 6, 2018 •
edited

Motivation for this change

This reduces the log size and thus should fix the darwin build of qtwebkit.
https://hydra.nixos.org/build/73631258

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested a review from ttuegel as a code owner May 6, 2018 15:21
@knedlsepp
qt5.qtwebkit: Reduce log size to fix hydra build
472f219 
This should fix the darwin build of qtwebkit.
@knedlsepp knedlsepp force-pushed the reduce-qt5.qtwebkit-logsize branch from f908ab0 to 472f219 Compare May 6, 2018 16:44
@knedlsepp knedlsepp changed the base branch from master to staging May 6, 2018 17:52
@knedlsepp knedlsepp changed the base branch from staging to master May 6, 2018 17:57
@matthewbauer matthewbauer merged commit 938fd30 into NixOS:master May 6, 2018
@matthewbauer
Copy link
Member

matthewbauer commented May 7, 2018 •
edited

It works! https://hydra.nixos.org/build/73714864

Thanks for working on these. Another one to look into is qtwebengine. I tried to fix it but it ends up trying to get the bundled xcode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @matthewbauer @GrahamcOfBorg