lib/strings.nix: fixes & additions #40048
Conversation
This makes things match ‘buildInputs’ where inputs are allowed to be null.
This adds the following to lib/strings.nix: - makeXdgPath - makeManPath - makeInfoPath
GrahamcOfBorg
added
10.rebuild-darwin: 0
| @@ -126,6 +126,18 @@ rec { | |||
| */ | |||
| makePerlPath = makeSearchPathOutput "lib" "lib/perl5/site_perl"; | |||
|
|
|||
| /* Construct an XDG path. Suitable to use as XDG_DATA_DIRS. | |||
| */ | |||
| makeXdgPath = makeSearchPathOutput "xdg" "share"; | |||
There was a problem hiding this comment.
This should probably be named makeDatadirPath. I would expect XDG path to be etc/xdg or share/xdg. Also why are you using the xdg output, datadir is usually in out?
There was a problem hiding this comment.
That might be a better name. Do packages come with /etc/xdg files though? My understanding is that the user supplies them. For this to make sense we would definitely need to define the xdg output. The idea was to put all of the FreeDesktop standardized directories there are like /share/applications, /share/icons, /share/mime, and /share/menus in one place.
Anyway the FreeDesktop directories are useful in free systems like Linux but not so useful on my Mac where the Applications directory is used instead. Having an output for just the XDG stuff would be useful, I think. icons especially can add up in closure size.
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
https://standards.freedesktop.org/menu-spec/menu-spec-latest.html
https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
https://standards.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html
There was a problem hiding this comment.
Do packages come with /etc/xdg files though?
e.g polkit_gnome
For this to make sense we would definitely need to define the xdg output. The idea was to put all of the FreeDesktop standardized directories there are like
/share/applications,/share/icons,/share/mime, and/share/menusin one place.
If we modify the setup hooks and everything (we rely on environment.pathsToLink to get these to the environment), sure. Icons should probably stay, since they are often used by the app itself.
Adds 3 new functions:
-makeXdgPath
-makeInfoPath
-makeManPath
Also allows you to put null in a search path. So something like this will work:
(notice that libintl will be null on Glibc systems).