Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 21be546c51d1
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 8cf420e62feb
Choose a head ref
  • 6 commits
  • 6 files changed
  • 1 contributor

Commits on Apr 28, 2018

  1. mpir: Build with C++ support

    This is needed by Alkimia which I'm going to package soon as part of
    KMyMoney.
    
    I enabled this by default, because it doesn't increase the closure size
    a whole lot (only around 150 KiB):
    
    $ nix-store -q --size /nix/store/...old...-mpir-3.0.0
    1223248
    $ nix-store -q --size /nix/store/...new...-mpir-3.0.0
    1377136
    
    Introducing an option for enabling/disabling this is not worth it,
    because it doesn't conflict with anything and the size increase is the
    only drawback and we can still make it configurable if we want someday.
    
    Signed-off-by: aszlig <aszlig@nix.build>
    Cc: @7c6f434c
    aszlig committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    6134887 View commit details
    Browse the repository at this point in the history
  2. kdewebkit: Add package expression

    This is one of the requirements of KMyMoney and packaging is quite
    straightforward with no unexpected traps.
    
    Signed-off-by: aszlig <aszlig@nix.build>
    Cc: @ttuegel
    aszlig committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    5370b82 View commit details
    Browse the repository at this point in the history
  3. alkimia: init at 7.0.1

    This is used by KMyMoney and also the reason why I needed to add C++
    support to MPIR in the parent commit.
    
    The reason why I didn't add myself as a maintainer is because I'm not
    personally using KMyMoney and thus Alkimia.
    
    Signed-off-by: aszlig <aszlig@nix.build>
    aszlig committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    d2b8d8b View commit details
    Browse the repository at this point in the history
  4. kmymoney: init at 5.0.1

    I tried to use -DENABLE_SQLCIPHER and also passed the right directories
    to the Qt 5 source of the QSQLiteDriver but CMake then failed to run
    qt4_automoc, by which I'd imply that SQLCipher is not maintained
    anymore (after all KMyMoney using qgpgme as well, which doesn't require
    sources).
    
    Another odd thing is that CMake reports that the weboob plugin is
    disabled, but after inspecting it turns out that the reporting is just
    wrong. This is already fixed upstream but not yet released in
    KDE/kmymoney@8b086cf.
    
    In addition of running the upstream test suite I have manually tested a
    few things in a VM by using the following Nix expression:
    
      (import <nixpkgs/nixos> {
        configuration = { pkgs, ... }: {
          environment.systemPackages = with pkgs; [
            kmymoney aqbanking gwenhywfar libchipcard python2Packages.weboob
            kgpg
          ];
          users.users.test.isNormalUser = true;
          virtualisation.diskSize = 4096;
          virtualisation.memorySize = 2048;
          services.xserver = {
            enable = true;
            inherit ((import <nixpkgs/nixos> {}).config.services.xserver) layout;
            displayManager.sddm.enable = true;
            displayManager.sddm.autoLogin.enable = true;
            displayManager.sddm.autoLogin.user = "test";
            desktopManager.default = "plasma5";
            desktopManager.plasma5.enable = true;
          };
        };
      }).vm
    
    The things I have tested in particular are:
    
      * Basic startup
      * Completing the wizard
      * Add some test transactions
      * GPG encryption
      * Generation of charts and reports
      * Rough check whether OFX integration lists supported financial
        institutions.
      * Small check of AqBanking implementation, whether accounts and users
        can be configured, but didn't test actual connectivity with a
        financial institution.
      * Check of Weboob integration with a test PayPal backend, however also
        just with a dummy account and without actually connecting to PayPal.
    
    One of the upstream tests "reports-chart-test" seems to fail even though
    generating charts and reports are working when testing manually. It also
    seems that this is the case on other distributions, for example Gentoo
    has disabled that test as well:
    
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5169cec68fa6fd67841
    
    Note that I didn't add myself as a maintainer because I'm not personally
    using KMyMoney but just packaged it for someone else. I hope this is
    useful for other people, so that maybe someday[TM] there will be a
    proper maintainer.
    
    Signed-off-by: aszlig <aszlig@nix.build>
    Cc: @ttuegel
    aszlig committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    93042b7 View commit details
    Browse the repository at this point in the history
  5. alkimia: Add meta.longDescription

    @7c6f434c wrote in [1]:
    
       Maybe copy-paste the upstream "Alkimia is the infrastructure for
       common storage and business logic that will be used by all financial
       applications in KDE. The target is to share financial related
       information over application bounderies." as longDescription for
       Alkimia? The current description makes me want to look up the
       homepage to find out what it actually is (then I do, and despair).
    
    [1]: #39647 (comment)
    
    Signed-off-by: aszlig <aszlig@nix.build>
    aszlig committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    9e88342 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2018

  1. Merge pull request #39647 (Add KMyMoney)

    This adds KMyMoney, a finance manager for KDE plus a few required
    dependencies.
    
    I ran the upstream test suite as well as the following manual tests:
    
      * Basic startup
      * Completing the wizard
      * Add some test transactions
      * GPG encryption
      * Generation of charts and reports
      * Rough check whether OFX integration lists supported financial
        institutions.
      * Small check of AqBanking implementation, whether accounts and users
        can be configured, but didn't test actual connectivity with a
        financial institution.
      * Check of Weboob integration with a test PayPal backend, however also
        just with a dummy account and without actually connecting to PayPal.
    
    On top of that, the application already is being used by the person
    requesting me to package this, so I'd guess it works well enough.
    
    I'm merging this without the review from @ttuegel because it only adds
    packages and doesn't change anything fundamental about the KDE
    ecosystem.
    
    The only change here is to add C++ support to "mpir", where the
    maintainer (@7c6f434c) has approved the change.
    aszlig committed May 5, 2018
    Configuration menu
    Copy the full SHA
    8cf420e View commit details
    Browse the repository at this point in the history