Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkcast: drop and replace with xscast #40026

Merged
merged 3 commits into from May 6, 2018
Merged

mkcast: drop and replace with xscast #40026

merged 3 commits into from May 6, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 6, 2018 •
edited

Motivation for this change

https://github.com/KeyboardFire/mkcast#obsolete

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
mkcast: remove
c29fcd9 
The package has been declared as unmaintained, `xscast` is the way to
go: https://github.com/KeyboardFire/mkcast#obsolete
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xscast

Partial log (click to expand)

patching script interpreter paths in /nix/store/wg02jyg8z74sdib48jvwrpc4427f4sq2-xscast-unstable-2016-07-26/bin
/nix/store/wg02jyg8z74sdib48jvwrpc4427f4sq2-xscast-unstable-2016-07-26/bin/xscast: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wg02jyg8z74sdib48jvwrpc4427f4sq2-xscast-unstable-2016-07-26
gzipping man pages under /nix/store/wg02jyg8z74sdib48jvwrpc4427f4sq2-xscast-unstable-2016-07-26/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wg02jyg8z74sdib48jvwrpc4427f4sq2-xscast-unstable-2016-07-26/bin
patching script interpreter paths in /nix/store/wg02jyg8z74sdib48jvwrpc4427f4sq2-xscast-unstable-2016-07-26
checking for references to /build in /nix/store/wg02jyg8z74sdib48jvwrpc4427f4sq2-xscast-unstable-2016-07-26...
/nix/store/wg02jyg8z74sdib48jvwrpc4427f4sq2-xscast-unstable-2016-07-26

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xscast

Partial log (click to expand)

patching script interpreter paths in /nix/store/cpm8p7fsskgcp6clqcjwam25m8kgxsl0-xscast-unstable-2016-07-26/bin
/nix/store/cpm8p7fsskgcp6clqcjwam25m8kgxsl0-xscast-unstable-2016-07-26/bin/xscast: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cpm8p7fsskgcp6clqcjwam25m8kgxsl0-xscast-unstable-2016-07-26
gzipping man pages under /nix/store/cpm8p7fsskgcp6clqcjwam25m8kgxsl0-xscast-unstable-2016-07-26/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cpm8p7fsskgcp6clqcjwam25m8kgxsl0-xscast-unstable-2016-07-26/bin
patching script interpreter paths in /nix/store/cpm8p7fsskgcp6clqcjwam25m8kgxsl0-xscast-unstable-2016-07-26
checking for references to /build in /nix/store/cpm8p7fsskgcp6clqcjwam25m8kgxsl0-xscast-unstable-2016-07-26...
/nix/store/cpm8p7fsskgcp6clqcjwam25m8kgxsl0-xscast-unstable-2016-07-26

@Ma27 Ma27 changed the title mkcast: drop and replace with xcast mkcast: drop and replace with xscast May 6, 2018
Mic92
Mic92 reviewed May 6, 2018
View reviewed changes
pkgs/applications/video/xscast/default.nix Outdated
patchShebangs $out/bin

wrapProgram "$out/bin/xscast" \
--prefix PATH : ${stdenv.lib.makeBinPath [ ffmpeg dzen2 xorg.xwininfo xorg.xinput imagemagick ]}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an extra } at the end that prevents xscast to find convert from imagemagick.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch sorry! Thanks for catching this 😅

@Mic92 Mic92 merged commit f579865 into NixOS:master May 6, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Merge failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Merge failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xscast

Partial log (click to expand)

patching script interpreter paths in /nix/store/qmy2bw57j4l464ni55ibsphacv7k4z43-xscast-unstable-2016-07-26/bin
/nix/store/qmy2bw57j4l464ni55ibsphacv7k4z43-xscast-unstable-2016-07-26/bin/xscast: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qmy2bw57j4l464ni55ibsphacv7k4z43-xscast-unstable-2016-07-26
gzipping man pages under /nix/store/qmy2bw57j4l464ni55ibsphacv7k4z43-xscast-unstable-2016-07-26/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qmy2bw57j4l464ni55ibsphacv7k4z43-xscast-unstable-2016-07-26/bin
patching script interpreter paths in /nix/store/qmy2bw57j4l464ni55ibsphacv7k4z43-xscast-unstable-2016-07-26
checking for references to /build in /nix/store/qmy2bw57j4l464ni55ibsphacv7k4z43-xscast-unstable-2016-07-26...
/nix/store/qmy2bw57j4l464ni55ibsphacv7k4z43-xscast-unstable-2016-07-26

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xscast

Partial log (click to expand)

patching script interpreter paths in /nix/store/ll9680rsp8wrjrh0638h660gdlgxsnfb-xscast-unstable-2016-07-26/bin
/nix/store/ll9680rsp8wrjrh0638h660gdlgxsnfb-xscast-unstable-2016-07-26/bin/xscast: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ll9680rsp8wrjrh0638h660gdlgxsnfb-xscast-unstable-2016-07-26
gzipping man pages under /nix/store/ll9680rsp8wrjrh0638h660gdlgxsnfb-xscast-unstable-2016-07-26/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ll9680rsp8wrjrh0638h660gdlgxsnfb-xscast-unstable-2016-07-26/bin
patching script interpreter paths in /nix/store/ll9680rsp8wrjrh0638h660gdlgxsnfb-xscast-unstable-2016-07-26
checking for references to /build in /nix/store/ll9680rsp8wrjrh0638h660gdlgxsnfb-xscast-unstable-2016-07-26...
/nix/store/ll9680rsp8wrjrh0638h660gdlgxsnfb-xscast-unstable-2016-07-26

@Ma27 Ma27 deleted the mkcast-deprecation branch May 6, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @Mic92