Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.scrapy: enable darwin build #40021

Merged
merged 1 commit into from May 6, 2018
Merged

pythonPackages.scrapy: enable darwin build #40021

merged 1 commit into from May 6, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 6, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner May 6, 2018 04:44
@Mic92
Copy link
Member

Mic92 commented May 6, 2018

@GrahamcOfBorg build pythonPackages.scrapy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.scrapy

Partial log (click to expand)

tests/test_utils_python.py::UtilsPythonTestCase::test_stringify_dict_keys_only
  /build/Scrapy-1.5.0/tests/test_utils_python.py:176: ScrapyDeprecationWarning: Call to deprecated function stringify_dict.
    d2 = stringify_dict(d)

tests/test_utils_python.py::UtilsPythonTestCase::test_stringify_dict_tuples
  /build/Scrapy-1.5.0/tests/test_utils_python.py:167: ScrapyDeprecationWarning: Call to deprecated function stringify_dict.
    d2 = stringify_dict(tuples, keys_only=False)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
====== 1530 passed, 10 skipped, 13 xfailed, 32 warnings in 203.41 seconds ======

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.scrapy

Partial log (click to expand)

  /private/tmp/nix-build-python2.7-Scrapy-1.5.0.drv-0/Scrapy-1.5.0/tests/test_utils_python.py:176: ScrapyDeprecationWarning: Call to deprecated function stringify_dict.
    d2 = stringify_dict(d)

tests/test_utils_python.py::UtilsPythonTestCase::test_stringify_dict_tuples
  /private/tmp/nix-build-python2.7-Scrapy-1.5.0.drv-0/Scrapy-1.5.0/tests/test_utils_python.py:167: ScrapyDeprecationWarning: Call to deprecated function stringify_dict.
    d2 = stringify_dict(tuples, keys_only=False)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
====== 1502 passed, 10 skipped, 13 xfailed, 32 warnings in 335.05 seconds ======
/nix/store/1h4xwddwmrxp2i9aaiwqcsqy9z7hjvs7-python2.7-Scrapy-1.5.0

@Mic92 Mic92 merged commit 6013c95 into NixOS:master May 6, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.scrapy

Partial log (click to expand)

  /build/Scrapy-1.5.0/tests/test_utils_python.py:176: ScrapyDeprecationWarning: Call to deprecated function stringify_dict.
    d2 = stringify_dict(d)

tests/test_utils_python.py::UtilsPythonTestCase::test_stringify_dict_tuples
  /build/Scrapy-1.5.0/tests/test_utils_python.py:167: ScrapyDeprecationWarning: Call to deprecated function stringify_dict.
    d2 = stringify_dict(tuples, keys_only=False)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
====== 1530 passed, 10 skipped, 13 xfailed, 32 warnings in 909.81 seconds ======
/nix/store/4afa4xln9cxcggsln9qk8w8vlg4mb3il-python2.7-Scrapy-1.5.0

@marsam marsam deleted the feature/enable-scrapy-darwin branch May 6, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @Mic92 @GrahamcOfBorg