Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liblapack: 3.4.1 -> 3.8.0 #40041

Merged
merged 1 commit into from May 7, 2018
Merged

liblapack: 3.4.1 -> 3.8.0 #40041

merged 1 commit into from May 7, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented May 6, 2018 •
edited

Motivation for this change

Fixes #37868.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau mentioned this pull request May 6, 2018
Closed
@7c6f434c
Copy link
Member

7c6f434c commented May 6, 2018

I hope your «trusted» status has been deployed and I don't need to ask ofborg do a test build…

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: liblapack

Partial log (click to expand)

../configure: line 482: can't create lib/Makefile: nonexistent directory
../configure: line 483: can't create lib/Makefile: nonexistent directory
../configure: line 484: can't create lib/Makefile: nonexistent directory
../configure: line 485: can't create lib/Makefile: nonexistent directory
../configure: line 541: can't create lib/Makefile: nonexistent directory
DONE configure
/nix/store/8sd7p53snnl8iszbif15mkax2mivj424-stdenv-linux/setup: line 100: include/atlas_cacheedge.h: No such file or directory
builder for '/nix/store/2dl1byn6jnf62x1z8d3c0as4yy9368kl-atlas-3.10.3.drv' failed with exit code 1
cannot build derivation '/nix/store/45fkv134fv6cd12by9iz1bfy0js8pclg-liblapack-3.8.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/45fkv134fv6cd12by9iz1bfy0js8pclg-liblapack-3.8.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: liblapack

Partial log (click to expand)

-- Installing: /nix/store/m8bgjcy0fhc1l02kpz2s7ayj6gd5p017-liblapack-3.8.0/lib/cmake/lapack-3.8.0/lapack-config.cmake
-- Installing: /nix/store/m8bgjcy0fhc1l02kpz2s7ayj6gd5p017-liblapack-3.8.0/lib/cmake/lapack-3.8.0/lapack-config-version.cmake
-- Installing: /nix/store/m8bgjcy0fhc1l02kpz2s7ayj6gd5p017-liblapack-3.8.0/lib/liblapack.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m8bgjcy0fhc1l02kpz2s7ayj6gd5p017-liblapack-3.8.0
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m8bgjcy0fhc1l02kpz2s7ayj6gd5p017-liblapack-3.8.0/lib
patching script interpreter paths in /nix/store/m8bgjcy0fhc1l02kpz2s7ayj6gd5p017-liblapack-3.8.0
checking for references to /build in /nix/store/m8bgjcy0fhc1l02kpz2s7ayj6gd5p017-liblapack-3.8.0...
/nix/store/m8bgjcy0fhc1l02kpz2s7ayj6gd5p017-liblapack-3.8.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: liblapack

Partial log (click to expand)

clang-5.0: warning: argument unused during compilation: '--param ssp-buffer-size=4' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
/nix/store/0qbic4ijsyhhl1d8bhh9f52innqfp3il-gfortran-wrapper-7.3.0/bin/gcc -DL2SIZE=33554432 -I/private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/include -I/private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/..//include -I/private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/..//include/contrib -DAdd_ -DF77_INTEGER=int -DStringSunStyle -DATL_OS_OSX -DATL_ARCH_IBMz13 -DATL_SSE3 -DATL_SSE2 -DATL_USE64BITS -m64  -O -fomit-frame-pointer -msse3 -m64 -o xemit_lamch emit_lamch.o -lm
/private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/bin/ATLrun.sh /private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/tune/sysinfo xemit_lamch
cp res/atlas_?lamch.h /private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/include/.
make[3]: Leaving directory '/private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/tune/sysinfo'
make[2]: Leaving directory '/private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/bin'
building of '/nix/store/j37l2l0z6qd0scrpdwv4d18k18r684b4-atlas-3.10.3.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/wipnbljgkpl9m66xijjz7a7lmygjm0cb-liblapack-3.8.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wipnbljgkpl9m66xijjz7a7lmygjm0cb-liblapack-3.8.0.drv' failed

@timokau
Copy link
Member Author

timokau commented May 6, 2018

Yeah it was :)

The arm atlas failure is known and the darwin one is just a timeout. I'm still locally running a nox-review to make sure the reason liblapack was pinned at an old version is gone. Since some of its reverse dependencies have a slow build, thats taking a while.

I'll ping you when thats done.

@timokau
Copy link
Member Author

timokau commented May 6, 2018

Alright it succeeded, I think this is ready for merge.

@7c6f434c
Copy link
Member

7c6f434c commented May 7, 2018

OK, thanks.

@7c6f434c 7c6f434c merged commit 903ae1e into NixOS:master May 7, 2018
dtzWill
dtzWill reviewed May 8, 2018
View reviewed changes
pkgs/top-level/all-packages.nix
liblapack = liblapackWithAtlas;
liblapack_3_5_0 = liblapack_3_5_0WithAtlas;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing these, the comment right above this needs to be updated as well. (since it mentions 3.5.0, etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right somehow I never read that comment. It doesn't really explain why it was pinned at 3.4.1 either.

Should I just remove it? I doesn't really provide any value anymore.

@timokau timokau deleted the liblapack-3.8.0 branch May 8, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill dtzWill left review comments

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @7c6f434c @GrahamcOfBorg @dtzWill