Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: update 2.0.106600.0904 -> 2.0.123200.0405, cleanup #40018

Merged
merged 1 commit into from May 6, 2018

Conversation

danbst
Copy link
Contributor

@danbst danbst commented May 5, 2018

Apart from version update:

  • remove some packages from LD_LIBRARY_PATH. I haven't found any
    references for them. Most of them were copypasted from AUR expression
    (closure size 347Mb -> 328Mb)
  • found an implicit reference to pidof (procps package), in my case this caused warnings
    about mismatched Glibc version. I've found implicit reference to sh too,
    with Glibc warning too, but I don't know how to fix this, and looks like it's
    only a warning
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Apart from version update:
- remove some packages from `LD_LIBRARY_PATH`. I haven't found any
references for them. Most of them were copypasted from AUR expression
- found an implicit reference to `pidof`, in my case this caused warnings
about mismatched Glibc version. I've found implicit reference to `sh` too,
with Glibc warning too, but I don't know how to fix this, and looks like it's
only a warning
@joachifm
Copy link
Contributor

joachifm commented May 6, 2018

Thank you

@danbst danbst deleted the zoom-us-update branch May 6, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants