Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dunst: add wrapper to find librsvg #40050

Merged
merged 1 commit into from May 16, 2018
Merged

dunst: add wrapper to find librsvg #40050

merged 1 commit into from May 16, 2018

Conversation

rycee
Copy link
Member

@rycee rycee commented May 6, 2018

Motivation for this change

To make dunst work better with SVG icons. Resolves nix-community/home-manager#256.

This should probably also be backported to 18.03.

Maintainer CC: @domenkozar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dunst

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/czjpa0yyyxqxgrlq5z90z8zv738aar7l-dunst-1.3.1/lib  /nix/store/czjpa0yyyxqxgrlq5z90z8zv738aar7l-dunst-1.3.1/bin
patching script interpreter paths in /nix/store/czjpa0yyyxqxgrlq5z90z8zv738aar7l-dunst-1.3.1
checking for references to /build in /nix/store/czjpa0yyyxqxgrlq5z90z8zv738aar7l-dunst-1.3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/ppqgvmnngfwmk4zbl5d03w9nvfjhl8w1-dunst-1.3.1-man
gzipping man pages under /nix/store/ppqgvmnngfwmk4zbl5d03w9nvfjhl8w1-dunst-1.3.1-man/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ppqgvmnngfwmk4zbl5d03w9nvfjhl8w1-dunst-1.3.1-man
checking for references to /build in /nix/store/ppqgvmnngfwmk4zbl5d03w9nvfjhl8w1-dunst-1.3.1-man...
/nix/store/czjpa0yyyxqxgrlq5z90z8zv738aar7l-dunst-1.3.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dunst

Partial log (click to expand)

strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3ci7liih2s9gk6v7dv2vsnrh95yjg75p-dunst-1.3.1/lib  /nix/store/3ci7liih2s9gk6v7dv2vsnrh95yjg75p-dunst-1.3.1/bin
patching script interpreter paths in /nix/store/3ci7liih2s9gk6v7dv2vsnrh95yjg75p-dunst-1.3.1
checking for references to /build in /nix/store/3ci7liih2s9gk6v7dv2vsnrh95yjg75p-dunst-1.3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/zjpf47xi63kqfpkz5jz13lj8w5v4n9j0-dunst-1.3.1-man
gzipping man pages under /nix/store/zjpf47xi63kqfpkz5jz13lj8w5v4n9j0-dunst-1.3.1-man/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/zjpf47xi63kqfpkz5jz13lj8w5v4n9j0-dunst-1.3.1-man
checking for references to /build in /nix/store/zjpf47xi63kqfpkz5jz13lj8w5v4n9j0-dunst-1.3.1-man...
/nix/store/3ci7liih2s9gk6v7dv2vsnrh95yjg75p-dunst-1.3.1

@xeji xeji merged commit e3b3eac into NixOS:master May 16, 2018
xeji pushed a commit that referenced this pull request May 16, 2018
@rycee @xeji
dunst: add wrapper to find librsvg (#40050)
ee951c3 
(cherry picked from commit e3b3eac and
resolved merge conflict)
@xeji
Copy link
Contributor

xeji commented May 16, 2018

backported in ee951c3

@rycee rycee deleted the fix/dunst/svg branch May 18, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rycee @GrahamcOfBorg @xeji