draftsight: 2017-SP2 -> 2018-SP2, remove gstreamer #40020
Conversation
Hodapp87
changed the title
Hodapp87
changed the title
| echo "Ignoring broken link $lib" | ||
| fi | ||
| done | ||
| # These libraries shouldn't really be here anyway: |
There was a problem hiding this comment.
A nit: It strikes me that all these paths follow a predictable pattern, is it more robust to use expansion/find here?
| @@ -54,12 +85,12 @@ stdenv.mkDerivation { | |||
| src = requireFile { | |||
| name = "draftSight.deb"; | |||
| url = "https://www.3ds.com/?eID=3ds_brand_download&uid=41&pidDown=13426&L=0"; | |||
There was a problem hiding this comment.
ArchLinux is using the following URL: http://dl-ak.solidworks.com/nonsecure/$pkgname/$pkgver/draftSight.rpm, see: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=draftsight#n32 might be a better choice as it includes the version.
There was a problem hiding this comment.
I just added this change and that URL scheme seems to work fine for the .deb, but are maintainers okay with hotlinking like this? I vaguely recall that when I did the original PR for DraftSight last year I had discussed things with people and the preference was to avoid bypassing license screens like this.
There was a problem hiding this comment.
It seems "safer" to respect the screen, in general anyway. Maybe check with upstream first? It's kind of annoying & user unfriendly but if that's the way upstream intends it, that should be respected.
Also, fixed URL scheme to link directly. Addressing NixOS#39975
Motivation for this change
This is addressing #39975. In addition, since the same URL is always used for Draftsight while the versions are updated, the hashes were all wrong - so the version required updating anyway.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)