-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix resolv on windows #5158
fix resolv on windows #5158
Conversation
|
sun.net.dns.ResolverConfiguration is marked as deprecated, but it still works I think the only way to do this right and fix https://bugs.ruby-lang.org/issues/12604 is to reimplement this What do you think? Should I try it or is there a better way? |
@ahorek Is this fix perhaps "good enough" to merge now in case we can't do the "right" fix before the 9.2 release (within a week from now)? |
my only concern is that sun.net.dns.ResolverConfiguration will become deprecated (I tested it on Oracle's Java 8 and Java 10 and it works fine for now) |
A valid concern. There are builds of 11, can you try to test one of them too? That would get us working into the next LTS version of OpenJDK.
Yikes! 😨 cc @enebo |
I've never used jnr.ffi before and I'm a little bit stucked :). Maybe someone could help me with it? #5178 |
@ahorek thanks for the first stab too. I agree that jnr/ffi and friends are super confusing in this case. Using the previous call for number of bytes to next call is weird. In Ruby FFI it was a bit easier to figure out. Plus Ruby... |
bug #4755