Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/system/boot/luksroot: remove comment about input_leds for caps lock #40052

Merged
merged 1 commit into from May 9, 2018
Merged

modules/system/boot/luksroot: remove comment about input_leds for caps lock #40052

merged 1 commit into from May 9, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 6, 2018

Since f2a9f9a, we already load
"input_leds", so this comment isn't useful anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@flokli
modules/system/boot/luksroot: remove comment about input_leds for cap…
5855459 
…s lock

Since f2a9f9a, we already load
"input_leds", so this comment isn't useful anymore.
@matthewbauer matthewbauer merged commit 0b58a5b into NixOS:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @matthewbauer @GrahamcOfBorg