Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/modules/services/scheduling/fcron: add setuid to fcrontab #40037

Merged
merged 1 commit into from Jun 2, 2018
Merged

nixos/modules/services/scheduling/fcron: add setuid to fcrontab #40037

merged 1 commit into from Jun 2, 2018

Conversation

alunduil
Copy link
Contributor

@alunduil alunduil commented May 6, 2018

Motivation for this change

Without fcrontab being setuid, every attempt by an user in the fcron
group to edit their own crontab (via fcrontab -e) results in the
following error:

2018-05-06 11:29:07 ERROR could not change euid to 273: Operation not permitted
2018-05-06 11:29:07 ERROR fcron child aborted: this does not affect the main fcron daemon, but this may prevent a job from being run or an email from being sent.

Adding setuid by hand has resolved this issue and aligns with the way
fcrontab is installed on other distributions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@alunduil
nixos/modules/services/scheduling/fcron: add setuid to fcrontab
fdebbce 
Without fcrontab being setuid, every attempt by an user in the fcron
group to edit their own crontab (via `fcrontab -e`) results in the
following error:

```
2018-05-06 11:29:07 ERROR could not change euid to 273: Operation not permitted
2018-05-06 11:29:07 ERROR fcron child aborted: this does not affect the main fcron daemon, but this may prevent a job from being run or an email from being sent.
```

Adding setuid by hand has resolved this issue and aligns with the way
fcrontab is installed on other distributions.
@alunduil
Copy link
Contributor Author

alunduil commented May 6, 2018

Is there anything special I need to do to get this merged into the current stable channel as well? Otherwise, let me know if there are any changes I need to make. Thanks!

@matthewbauer matthewbauer merged commit e4746bd into NixOS:master Jun 2, 2018
@alunduil alunduil deleted the fix-fcrontab-setuid branch June 17, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alunduil @matthewbauer @GrahamcOfBorg