Removed unnecessary codes and modify a code lines to support to UNIT coin. #1017
Conversation
- Removed unnecessary PreInfo.cs code - Added a new PropertyConvertor.cs - Modify the following codes to support a UNIT coin - MiningInfo.cs - DaemonBase.cs Specially thanks to @flyx2888 for UNIT coin code modification.
|
@bonesoul I've opened a new PR for previous change. please apply this PR |
|
okay lot better. thanks |
|
though the tests are failing;
i guess u forgot to include the file? |
|
@bonesoul Sorry. it was remaining on untracked file status. I forgot to issue a git add . |
|
Just my private opinion but I want to call this of CoiniumServ as ver 2.6.4 to fixed various issues. |
Fixed wrong URL information about CoiniumServ on /srv/web/default/views/layout/footer.cshtml
Removed Coinbase.com button it seems does not work either so. <a class="coinbase-button" data-code="cf6bb9334d09f07ad3abbe5894702ae9" data-button-style="custom_small" href="https://coinbase.com/checkouts/cf6bb9334d09f07ad3abbe5894702ae9">Donate Bitcoins</a> <script src="https://coinbase.com/assets/button.js" type="text/javascript"></script>
<li>Litecoin: ---> <li>Ethereum:
<a href="http://www.coiniumserv.com" target="_blank"> ---> https://github.com/bonesoul/CoiniumServ
| @@ -30,7 +30,7 @@ | |||
| You can directly donate to our following addresses;<br /><br /> | |||
| <ul> | |||
| <li>Bitcoin: <a href="bitcoin:1MMdwRZg4K9p6oH2bWUQdohbxGbAvXS1t1?label=CoiniumServ%20Donation"><code>1MMdwRZg4K9p6oH2bWUQdohbxGbAvXS1t1</code></a></li> | |||
| <li>Litecoin: <a href="ethereum:Ld8cy4ucf3FYThtfTnRQFFp5MKK9rZHjNg?label=CoiniumServ%20Donation"><code>0x61aa3e0709e20bcb4aedc2607d4070f1db72e69b</code></a></li> | |||
| <li>Ethereum: <a href="ethereum:Ld8cy4ucf3FYThtfTnRQFFp5MKK9rZHjNg?label=CoiniumServ%20Donation"><code>0x61aa3e0709e20bcb4aedc2607d4070f1db72e69b</code></a></li> | |||
There was a problem hiding this comment.
This is still wrong. The eth address in the href does not match the displayed address. It's set to the litecoin address.
There was a problem hiding this comment.
@flyx2888 Yes but donation page displayed an Ethereum address. so this, not the issue.
There was a problem hiding this comment.
It's not an issue if they manually copy and paste. It's an issue if they click on the link.
Fixed Ethereum address in the code. 0x61aa3e0709e20bcb4aedc2607d4070f1db72e69b
0x61aa3e0709e20bcb4aedc2607d4070f1db72e69b
coin": "stronghands.json"
|
Do you any reasons to hesitate to merged this PR? Regards, |
|
@jeong760 nope i totally forgot about it, lemme check it and merge then if it's all okay. |
Removed unused Preinfo.cs class code from on /src/CoiniumServ/Daemon/Responses
Modify or add a code to support a UNIT(Universal Coin)
Add a new PropertyConvertor.cs class on /srv/CoiniumServ/Daemon/Converters/PropertyConverter.cs
Add a following code on MininInfo.cs on /srv/CoiniumServ/Daemon/Responses
[JsonProperty("netmh/s")] // added to support unit and possibly some other coins
private double NetMHps { get; set; }
Modify a following code on src\CoiniumServ\Daemon\DaemonBase.cs
using CoiniumServ.Daemon.Converters;
// process response with converter. needed for all coin wallets which gives non-standard info.
string jsonLC = PropertyConverter.DeserializeWithLowerCasePropertyNames(json).ToString();
_logger.Verbose("rx: {0}", jsonLC.PrettifyJson());
try
{
return JsonConvert.DeserializeObject(jsonLC);
}
Specially thanks to @flyx2888 to modify and add a new class for UNIT coin.
Regards,
John Ahn