Add nix-prefetch-github #39214

seppeljordan · 2018-04-20T09:34:44Z

Motivation for this change

This PR adds an application to nixpkgs to "prefetch" sources from github. For this purpose I also added a python package called "effect", because it is a dependency of "nix-prefetch-github"

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-04-20T10:10:11Z

pkgs/build-support/nix-prefetch-github/default.nix

+    requests
+  ];
+  meta = with lib; {
+    description = "prefetch sources from github";


https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

dotlambda · 2018-04-20T10:10:25Z

pkgs/build-support/nix-prefetch-github/default.nix

+
+in
+buildPythonApplication {
+  name = "nix-prefetch-github-${version}";


Please use pname and version instead.

dotlambda · 2018-04-20T10:11:08Z

pkgs/build-support/nix-prefetch-github/default.nix

+  src = fetchFromGitHub {
+    owner = "seppeljordan";
+    repo = "nix-prefetch-github";
+    rev = "b12ab7fe187924d8536d27b2ddf3bcccd2612b32";


It would be nicer to create releases/tags in the GitHub repo.

dotlambda · 2018-04-20T10:11:21Z

pkgs/development/python-modules/effect/default.nix

+  ];
+  doCheck = false;
+  meta = with lib; {
+    description = "pure effects for Python";


https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

dotlambda · 2018-04-20T10:11:31Z

pkgs/development/python-modules/effect/default.nix

+    six
+    attrs
+  ];
+  doCheck = false;


dotlambda · 2018-04-20T10:11:49Z

pkgs/top-level/all-packages.nix

@@ -20647,6 +20647,10 @@ with pkgs;

  nix-pin = callPackage ../tools/package-management/nix-pin { };

+  nix-prefetch-github = callPackages ../build-support/nix-prefetch-github {


callPackage

dotlambda · 2018-04-20T10:12:37Z

pkgs/build-support/nix-prefetch-github/default.nix

@@ -0,0 +1,36 @@
+{ buildPythonApplication


Please pass python3 or python3Packages instead.

FRidh · 2018-04-20T10:36:47Z

pkgs/development/python-modules/effect/default.nix

+let
+
+version = "0.11.0";
+pname = "effect";


no need to keep these out

Mic92 · 2018-04-21T11:18:52Z

Just as a side note: #21732 (comment)

seppeljordan · 2018-05-16T13:49:16Z

Hi, I think that I included all the suggestions that were given. Please tell me if there is more that I should change with this PR

dotlambda · 2018-05-22T11:10:17Z

pkgs/development/python-modules/effect/default.nix

+    inherit pname version;
+    sha256 = "1q75w4magkqd8ggabhhzzxmxakpdnn0vdg7ygj89zdc9yl7561q6";
+  };
+  buildInputs = [


checkInputs

dotlambda · 2018-05-22T11:10:40Z

pkgs/development/python-modules/effect/default.nix

+}:
+let
+
+in


Drop this let in.

dotlambda · 2018-05-22T11:11:50Z

pkgs/build-support/nix-prefetch-github/default.nix

+  src = fetchFromGitHub {
+    owner = "seppeljordan";
+    repo = "nix-prefetch-github";
+    rev = "b12ab7fe187924d8536d27b2ddf3bcccd2612b32";


Please create tags in your GitHub repo.

seppeljordan · 2018-05-22T18:27:50Z

@dotlambda thx for the review

lukateras · 2018-05-22T21:07:04Z

Maybe, let's phase out fetchFromGitHub in favor of fetchzip? This needs an RFC.

Mic92 · 2018-05-23T08:24:23Z

@GrahamcOfBorg build nix-prefetch-github

GrahamcOfBorg · 2018-05-23T08:24:45Z

Success on x86_64-darwin (full log)

Attempted: nix-prefetch-github

Partial log (click to expand)

reading manifest file 'src/nix_prefetch_github.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/nix_prefetch_github.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/a8szdagwdikvh0nkhsklkhqy871sw5ws-nix-prefetch-github-1.3

GrahamcOfBorg · 2018-05-23T08:25:00Z

Success on x86_64-linux (full log)

Attempted: nix-prefetch-github

Partial log (click to expand)

reading manifest file 'src/nix_prefetch_github.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/nix_prefetch_github.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ys2wb4hymcfwxfy6l6qalvagia7jp6ai-nix-prefetch-github-1.3

GrahamcOfBorg · 2018-05-23T08:25:21Z

Success on aarch64-linux (full log)

Attempted: nix-prefetch-github

Partial log (click to expand)

reading manifest file 'src/nix_prefetch_github.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/nix_prefetch_github.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/23rz8qw43xdp4f7qgy9wzrasakgh4lgx-nix-prefetch-github-1.3

seppeljordan requested a review from FRidh as a code owner April 20, 2018 09:34

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 20, 2018

dotlambda requested changes Apr 20, 2018

View reviewed changes

FRidh reviewed Apr 20, 2018

View reviewed changes

pkgs/development/python-modules/effect/default.nix Outdated

let

version = "0.11.0";

pname = "effect";

Copy link

Member

FRidh Apr 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to keep these out

pythonPackages.effect: init -> 0.11.0

101d1d1

seppeljordan force-pushed the add-nix-prefetch-github branch 2 times, most recently from 018ac73 to f28169d Compare May 15, 2018 13:07

dotlambda requested changes May 22, 2018

View reviewed changes

nix-prefetch-github: init -> 1.3

aca3198

seppeljordan force-pushed the add-nix-prefetch-github branch from f28169d to aca3198 Compare May 22, 2018 18:55

dotlambda added the 9.needs: community feedback label May 22, 2018

Mic92 merged commit 273c882 into NixOS:master May 23, 2018

FRidh mentioned this pull request May 28, 2018

nix-prefetch-github? #21732

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add nix-prefetch-github #39214

Add nix-prefetch-github #39214

seppeljordan commented Apr 20, 2018 •

edited

Loading

dotlambda Apr 20, 2018

dotlambda Apr 20, 2018

dotlambda Apr 20, 2018

dotlambda Apr 20, 2018

dotlambda Apr 20, 2018

dotlambda Apr 20, 2018

dotlambda Apr 20, 2018

FRidh Apr 20, 2018

Mic92 commented Apr 21, 2018

seppeljordan commented May 16, 2018

dotlambda May 22, 2018

dotlambda May 22, 2018

dotlambda May 22, 2018

seppeljordan commented May 22, 2018

lukateras commented May 22, 2018

Mic92 commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

		@@ -20647,6 +20647,10 @@ with pkgs;

		nix-pin = callPackage ../tools/package-management/nix-pin { };

		nix-prefetch-github = callPackages ../build-support/nix-prefetch-github {

+              }:
+              let
+              in

Add nix-prefetch-github #39214

Add nix-prefetch-github #39214

Conversation

seppeljordan commented Apr 20, 2018 • edited Loading

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 commented Apr 21, 2018

seppeljordan commented May 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seppeljordan commented May 22, 2018

lukateras commented May 22, 2018

Mic92 commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

seppeljordan commented Apr 20, 2018 •

edited

Loading