Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockhash: init at 0.3 #40737

Merged
merged 1 commit into from May 19, 2018
Merged

blockhash: init at 0.3 #40737

merged 1 commit into from May 19, 2018

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented May 18, 2018 •
edited

Motivation for this change

https://github.com/commonsmachinery/blockhash

This is a very simple C implementation of a perceptual hashing algorithm:

$ blockhash ~/pics/r4oNq75.jpg
ffffc38381c18181c5f9901b11d901ff08c3e1c3e5c9eb1dc20dca09e603ff9b  /home/infinisil/pics/r4oNq75.jpg
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: blockhash

Partial log (click to expand)

Waf: Leaving directory `/build/source/build'
'install' finished successfully (0.201s)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xmzik34qnjssz32fklhz1l290sfr2mik-blockhash-0.3
shrinking /nix/store/xmzik34qnjssz32fklhz1l290sfr2mik-blockhash-0.3/bin/blockhash
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xmzik34qnjssz32fklhz1l290sfr2mik-blockhash-0.3/bin
patching script interpreter paths in /nix/store/xmzik34qnjssz32fklhz1l290sfr2mik-blockhash-0.3
checking for references to /build in /nix/store/xmzik34qnjssz32fklhz1l290sfr2mik-blockhash-0.3...
/nix/store/xmzik34qnjssz32fklhz1l290sfr2mik-blockhash-0.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: blockhash

Partial log (click to expand)

Waf: Leaving directory `/build/source/build'
'install' finished successfully (0.007s)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dg04aipd9zy1fdlkin3s3kpsf175sbzc-blockhash-0.3
shrinking /nix/store/dg04aipd9zy1fdlkin3s3kpsf175sbzc-blockhash-0.3/bin/blockhash
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dg04aipd9zy1fdlkin3s3kpsf175sbzc-blockhash-0.3/bin
patching script interpreter paths in /nix/store/dg04aipd9zy1fdlkin3s3kpsf175sbzc-blockhash-0.3
checking for references to /build in /nix/store/dg04aipd9zy1fdlkin3s3kpsf175sbzc-blockhash-0.3...
/nix/store/dg04aipd9zy1fdlkin3s3kpsf175sbzc-blockhash-0.3

xeji
xeji reviewed May 18, 2018
View reviewed changes
pkgs/tools/graphics/blockhash/default.nix Outdated
};

nativeBuildInputs = [ python ];
buildInputs = [ pkgconfig imagemagick ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgconfig usually belongs in nativeBuildInputs.

@infinisil
Copy link
Member Author

Fixed that

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: blockhash

Partial log (click to expand)

Waf: Leaving directory `/build/source/build'
'install' finished successfully (0.143s)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q4r3vafp34mhf5byqk2z1xwgzcf5zvfs-blockhash-0.3
shrinking /nix/store/q4r3vafp34mhf5byqk2z1xwgzcf5zvfs-blockhash-0.3/bin/blockhash
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q4r3vafp34mhf5byqk2z1xwgzcf5zvfs-blockhash-0.3/bin
patching script interpreter paths in /nix/store/q4r3vafp34mhf5byqk2z1xwgzcf5zvfs-blockhash-0.3
checking for references to /build in /nix/store/q4r3vafp34mhf5byqk2z1xwgzcf5zvfs-blockhash-0.3...
/nix/store/q4r3vafp34mhf5byqk2z1xwgzcf5zvfs-blockhash-0.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: blockhash

Partial log (click to expand)

Waf: Leaving directory `/build/source/build'
'install' finished successfully (0.006s)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/idn6jj954pl7mj0bha88v6nb1fc9sl6a-blockhash-0.3
shrinking /nix/store/idn6jj954pl7mj0bha88v6nb1fc9sl6a-blockhash-0.3/bin/blockhash
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/idn6jj954pl7mj0bha88v6nb1fc9sl6a-blockhash-0.3/bin
patching script interpreter paths in /nix/store/idn6jj954pl7mj0bha88v6nb1fc9sl6a-blockhash-0.3
checking for references to /build in /nix/store/idn6jj954pl7mj0bha88v6nb1fc9sl6a-blockhash-0.3...
/nix/store/idn6jj954pl7mj0bha88v6nb1fc9sl6a-blockhash-0.3

@xeji
Copy link
Contributor

xeji commented May 19, 2018

Let's see if this builds on darwin as well
@GrahamcOfBorg build blockhash

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: blockhash

Partial log (click to expand)

/nix/store/idn6jj954pl7mj0bha88v6nb1fc9sl6a-blockhash-0.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: blockhash

Partial log (click to expand)

/nix/store/q4r3vafp34mhf5byqk2z1xwgzcf5zvfs-blockhash-0.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: blockhash

Partial log (click to expand)

installing
Waf: Entering directory `/private/tmp/nix-build-blockhash-0.3.drv-0/source/build'
+ install /nix/store/8zd23pj65gdz23jf57xxpgxj2m6mxviq-blockhash-0.3/bin/blockhash (from build/blockhash)
Waf: Leaving directory `/private/tmp/nix-build-blockhash-0.3.drv-0/source/build'
'install' finished successfully (0.011s)
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8zd23pj65gdz23jf57xxpgxj2m6mxviq-blockhash-0.3/bin
patching script interpreter paths in /nix/store/8zd23pj65gdz23jf57xxpgxj2m6mxviq-blockhash-0.3
/nix/store/8zd23pj65gdz23jf57xxpgxj2m6mxviq-blockhash-0.3

@xeji xeji merged commit c8a8ecb into NixOS:master May 19, 2018
@infinisil
Copy link
Member Author

Very nice

@infinisil infinisil deleted the add/blockhash branch May 19, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@infinisil @GrahamcOfBorg @xeji