Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/cjdns: fix service for i686 #40740

Merged
merged 1 commit into from May 19, 2018
Merged

nixos/cjdns: fix service for i686 #40740

merged 1 commit into from May 19, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented May 18, 2018

Motivation for this change

#40257. Failing test pointed to a bug in the systemd service: It failed to start because of the systemd unit option MemoryDenyWriteExecute = true, which doesn't seem to work on i686.

Things done
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@xeji
nixos/cjdns: fix service for i686
c136194 
service failed to start because of MemoryDenyWriteExecute = true,
which seems not to work on i686
@xeji xeji added the 9.needs: port to stable A PR needs a backport to the stable release. label May 18, 2018
@xeji xeji mentioned this pull request May 18, 2018
Closed
41 tasks
@xeji
Copy link
Contributor Author

xeji commented May 18, 2018

this only runs the 64bit test but let's do it anyway:
@GrahamcOfBorg test cjdns

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.cjdns

Partial log (click to expand)

error: the VM quit before connecting
the VM quit before connecting
cleaning up
killing carol (pid 593)
killing alice (pid 605)
killing bob (pid 617)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/ggx488l5k77mimnlwpg4k3kw2fdb1mki-vm-test-run-cjdns.drv' failed with exit code 255
error: build of '/nix/store/ggx488l5k77mimnlwpg4k3kw2fdb1mki-vm-test-run-cjdns.drv' failed

@xeji
Copy link
Contributor Author

xeji commented May 18, 2018

Test runs fine locally. Failure is an unrelated kernel panic during VM boot, probably an issue of the ofborg builder machine (seen these occasionally).

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.cjdns

Partial log (click to expand)

bob: running command: sync
bob: exit status 0
test script finished in 37.79s
cleaning up
killing carol (pid 627)
killing alice (pid 640)
killing bob (pid 653)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/cx13x39ivbapx8119hw6q99fcl4qiz7a-vm-test-run-cjdns

@xeji xeji merged commit f4ec18a into NixOS:master May 19, 2018
@xeji xeji deleted the fix-cjdns branch May 19, 2018 23:02
xeji added a commit that referenced this pull request May 20, 2018
@xeji
nixos/cjdns: fix service for i686 (#40740)
7dac244 
service failed to start because of MemoryDenyWriteExecute = true,
which seems not to work on i686

(cherry picked from commit f4ec18a)
@xeji
Copy link
Contributor Author

xeji commented May 20, 2018

backported in 7dac244

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @samueldr