pythonPackages.pynmea2: init at 1.12.0 #40757

oxzi · 2018-05-19T07:52:36Z

Motivation for this change

Adds the pynmea2 package to the nixpkgs.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda

Please change your commit message to pythonPackages.pynmea2: init at 1.12.0.

dotlambda · 2018-05-19T09:14:48Z

pkgs/development/python-modules/pynmea2/default.nix

+buildPythonPackage rec {
+  pname = "pynmea2";
+  version = "1.12.0";
+  name = "${pname}-${version}";


drop this line

dotlambda · 2018-05-19T09:15:47Z

pkgs/development/python-modules/pynmea2/default.nix

+    sha256 = "185wxn8gag9whxmysspbh8s7wn3sh1glgf508w2zzwi4lklryl7i";
+  };
+
+  # Tests are failing for Python 3 because the version is missing.


Which version of what is missing? You can set doCheck = isPy27.

I'm not quite sure, but the test fails with

_version (unittest.loader._FailedTest) ... ERROR ====================================================================== ERROR: _version (unittest.loader._FailedTest) ---------------------------------------------------------------------- AttributeError: module 'pynmea2' has no attribute '_version' ----------------------------------------------------------------------

We can try reenabling the tests once the appropriate checkPhase is set.

dotlambda · 2018-05-19T09:16:32Z

pkgs/development/python-modules/pynmea2/default.nix

@@ -0,0 +1,22 @@
+{ stdenv, lib, buildPythonPackage, fetchPypi }:


stdenv is not used

dotlambda · 2018-05-20T19:59:21Z

@GrahamcOfBorg build python2.pkgs.pynmea2 python3.pkgs.pynmea2

GrahamcOfBorg · 2018-05-20T19:59:51Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pynmea2, python3.pkgs.pynmea2

Partial log (click to expand)

warning: no previously-included files matching '*.pyc' found anywhere in distribution
writing manifest file 'pynmea2.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/rygi98hbm83v5r2v7mxwsacb436vd00w-python2.7-pynmea2-1.12.0
/nix/store/9g0dizzw6mhbhi84vb2y8hbf5v9srkif-python3.6-pynmea2-1.12.0

GrahamcOfBorg · 2018-05-20T19:59:55Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pynmea2, python3.pkgs.pynmea2

Partial log (click to expand)

warning: no files found matching 'LICENSE.txt'
warning: no previously-included files matching '__pycache__' found anywhere in distribution
warning: no previously-included files matching '*.pyc' found anywhere in distribution
writing manifest file 'pynmea2.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

dotlambda · 2018-05-22T10:14:34Z

Ran 0 tests in 0.000s

You'll probably have to set

checkPhase = ''
  py.test
'';

oxzi · 2018-05-23T10:18:06Z

Using pytest solved this issue and works for both Python 2 and 3. Thanks @dotlambda.

dotlambda · 2018-05-23T23:06:52Z

@GrahamcOfBorg build python2.pkgs.pynmea2 python3.pkgs.pynmea2

GrahamcOfBorg · 2018-05-23T23:07:29Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pynmea2, python3.pkgs.pynmea2

Partial log (click to expand)

test/test_proprietary.py ..............                                  [ 30%]
test/test_pynmea.py ..................                                   [ 60%]
test/test_rdi.py .                                                       [ 61%]
test/test_stream.py .....                                                [ 70%]
test/test_sxn.py ..                                                      [ 73%]
test/test_types.py ................                                      [100%]

========================== 60 passed in 0.35 seconds ===========================
/nix/store/j69j2sngfkn7rizcp8l2wq3ni80cpp0z-python2.7-pynmea2-1.12.0
/nix/store/k67dm5c6wznp5g0avvmy5yd63q9dzar4-python3.6-pynmea2-1.12.0

GrahamcOfBorg · 2018-05-23T23:08:11Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pynmea2, python3.pkgs.pynmea2

Partial log (click to expand)

test/test_proprietary.py ..............                                  [ 30%]
test/test_pynmea.py ..................                                   [ 60%]
test/test_rdi.py .                                                       [ 61%]
test/test_stream.py .....                                                [ 70%]
test/test_sxn.py ..                                                      [ 73%]
test/test_types.py ................                                      [100%]

========================== 60 passed in 5.57 seconds ===========================
/nix/store/01kqi2iyhp90i5widr48xwlfi99qblmn-python2.7-pynmea2-1.12.0
/nix/store/r770gx5nriap4lxyskp1wn5l40drhhwq-python3.6-pynmea2-1.12.0

oxzi requested a review from FRidh as a code owner May 19, 2018 07:52

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 19, 2018

dotlambda requested changes May 19, 2018

View reviewed changes

oxzi force-pushed the pynmea2-1.12.0 branch 2 times, most recently from 67ba777 to 4beca92 Compare May 19, 2018 09:50

dotlambda changed the title ~~pynmea2: init at 1.12.0~~ pythonPackages.pynmea2: init at 1.12.0 May 22, 2018

pythonPackages.pynmea2: init at 1.12.0

9e98103

oxzi force-pushed the pynmea2-1.12.0 branch from 4beca92 to 9e98103 Compare May 23, 2018 10:17

dotlambda merged commit b656e03 into NixOS:master May 23, 2018

oxzi deleted the pynmea2-1.12.0 branch June 13, 2018 11:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.pynmea2: init at 1.12.0 #40757

pythonPackages.pynmea2: init at 1.12.0 #40757

oxzi commented May 19, 2018

dotlambda left a comment

dotlambda May 19, 2018

dotlambda May 19, 2018

oxzi May 19, 2018

dotlambda May 22, 2018

dotlambda May 19, 2018

dotlambda commented May 20, 2018

GrahamcOfBorg commented May 20, 2018

GrahamcOfBorg commented May 20, 2018

dotlambda commented May 22, 2018

oxzi commented May 23, 2018

dotlambda commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

		@@ -0,0 +1,22 @@
		{ stdenv, lib, buildPythonPackage, fetchPypi }:

pythonPackages.pynmea2: init at 1.12.0 #40757

pythonPackages.pynmea2: init at 1.12.0 #40757

Conversation

oxzi commented May 19, 2018

Motivation for this change

Things done

dotlambda left a comment

Choose a reason for hiding this comment

dotlambda May 19, 2018

Choose a reason for hiding this comment

dotlambda May 19, 2018

Choose a reason for hiding this comment

oxzi May 19, 2018

Choose a reason for hiding this comment

dotlambda May 22, 2018

Choose a reason for hiding this comment

dotlambda May 19, 2018

Choose a reason for hiding this comment

dotlambda commented May 20, 2018

GrahamcOfBorg commented May 20, 2018

GrahamcOfBorg commented May 20, 2018

dotlambda commented May 22, 2018

oxzi commented May 23, 2018

dotlambda commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018