services.synergy: Use graphical target (fixes #9468) #40747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
reviewed
Jul 3, 2018
| path = [ pkgs.synergy ]; | ||
| serviceConfig.ExecStart = ''${pkgs.synergy}/bin/synergyc -f ${optionalString (cfgC.screenName != "") "-n ${cfgC.screenName}"} ${cfgC.serverAddress}''; | ||
| serviceConfig.Restart = "on-failure"; | ||
| }; | ||
| }) | ||
| (mkIf cfgS.enable { | ||
| systemd.services."synergy-server" = { | ||
| after = [ "network.target" ]; | ||
| systemd.user.services."synergy-server" = { |
There was a problem hiding this comment.
Does the server really need X11 for it to work?
Also, these services run in the user systemd session with this change, can this change behaviour? Is this intended like this?
There was a problem hiding this comment.
I believe this is all necessary, per #9468
There was a problem hiding this comment.
LGTM, just tested this on NixOS and it works 👍
infinisil
approved these changes
Jul 17, 2018
|
Oh one more thing: Can you change the commit message to use the |
|
@WhittlesJr can you fix the commit message? |
WhittlesJr
force-pushed
the
synergy-fix
branch
from
f3592f1
to
9a63f51
Compare
|
Arg, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Synergy client would not auto-start, because it tried to come up before there was a graphical target.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)