geojson: init at 2.3.0 #40762
Merged
geojson: init at 2.3.0 #40762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
May 19, 2018
| buildPythonPackage rec { | ||
| pname = "geojson"; | ||
| version = "2.3.0"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
The name attribute is added by buildPython* and should therefore be removed.
| sha256 = "06ihcb8839zzgk5jcv18kc6nqld4hhj3nk4f3drzcr8n8893v1y8"; | ||
| }; | ||
|
|
||
| # test_unicode_properties fails for Python 3 |
There was a problem hiding this comment.
Here you are:
======================================================================
ERROR: test_unicode_properties (test_features.FeaturesTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/build/geojson-2.3.0/tests/test_features.py", line 41, in test_unicode_properties
obj = geojson.load(file_)
File "/build/geojson-2.3.0/geojson/codec.py", line 43, in load
**kwargs)
File "/nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/lib/python3.6/json/__init__.py", line 296, in load
return loads(fp.read(),
File "/nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/lib/python3.6/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 28: ordinal not in range(128)
----------------------------------------------------------------------
There was a problem hiding this comment.
This is a common issue described in the Nixpkgs manual:
Unicode issues can typically be fixed by including glibcLocales in
buildInputscheckInputs and exporting LC_ALL=en_US.utf-8.
There was a problem hiding this comment.
I didn't knew about this one. Thanks for your help!
oxzi
force-pushed
the
python-geojson-2.3.0
branch
3 times, most recently
from
95251f2
to
8cc805c
Compare
oxzi
force-pushed
the
python-geojson-2.3.0
branch
from
8cc805c
to
2db356f
Compare
|
@GrahamcOfBorg build python.pkgs.geojson python3.pkgs.geojson |
|
Success on x86_64-darwin (full log) Attempted: python.pkgs.geojson, python3.pkgs.geojson Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python.pkgs.geojson, python3.pkgs.geojson Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python.pkgs.geojson, python3.pkgs.geojson Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds the geojson Python-module to nixpkgs
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)