Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: Fix darwin. #40752

Merged
merged 2 commits into from May 19, 2018
Merged

alacritty: Fix darwin. #40752

merged 2 commits into from May 19, 2018

Conversation

TravisWhitaker
Copy link
Contributor

Motivation for this change

Fixes alacritty on macOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label May 19, 2018
@Mic92
Copy link
Member

Mic92 commented May 19, 2018

@GrahamcOfBorg build alacritty

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: alacritty

Partial log (click to expand)

test src/meter.rs - meter (line 21) ... ok

test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/9qypamhwn0nyjr60rklr7rg5bxic72p9-alacritty-unstable-2018-04-16/bin
patching script interpreter paths in /nix/store/9qypamhwn0nyjr60rklr7rg5bxic72p9-alacritty-unstable-2018-04-16
/nix/store/9qypamhwn0nyjr60rklr7rg5bxic72p9-alacritty-unstable-2018-04-16

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: alacritty

Partial log (click to expand)


test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ny85d94zmz1f3yb7agp4qnfgycjvns7y-alacritty-unstable-2018-04-16/bin
patching script interpreter paths in /nix/store/ny85d94zmz1f3yb7agp4qnfgycjvns7y-alacritty-unstable-2018-04-16
checking for references to /build in /nix/store/ny85d94zmz1f3yb7agp4qnfgycjvns7y-alacritty-unstable-2018-04-16...
/nix/store/ny85d94zmz1f3yb7agp4qnfgycjvns7y-alacritty-unstable-2018-04-16

@Mic92
Copy link
Member

Mic92 commented May 19, 2018

@GrahamcOfBorg build alacritty

Mic92
Mic92 reviewed May 19, 2018
View reviewed changes
pkgs/applications/misc/alacritty/default.nix Outdated
@@ -50,18 +50,18 @@ let
];
in buildRustPackage rec {
name = "alacritty-unstable-${version}";
version = "2018-04-16";
version = "2018-05-09";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this as an opportunity to update the package.

Mic92
Mic92 approved these changes May 19, 2018
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when ofborg finishes.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: alacritty

Partial log (click to expand)

cannot build derivation '/nix/store/84na393x1c9fz0dg38mr9wjy9ipvrx5n-rust_curl-0.4.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/32qzfln4jm73a8rfsp2g005fyajpgk9g-rust_libgit2-sys-0.6.16.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ksynndvp97am6bdddbciv5gjv7gyh070-rust_crates-io-0.11.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/cxwcj0v4mc2giqyfp0ysnbm7z26ci1n1-rust_git2-0.6.8.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/q4v0f2qjb454v0w667c8fhhw6hv2my0i-rust_git2-curl-0.7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/kw96b9qnrv0wiwbfjxc7b3cpbd08whpv-rust_cargo-0.22.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/cyxhq07vmk985rr1n9mrc7z714d9w1lp-rust_cargo-vendor-0.1.13.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/xrdirlvjhhzw8fjpijsb5m7fcj23qd4b-alacritty-unstable-2018-05-09-vendor.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xx8mshil9y63ndbr9inz5lx94xzhfvvs-alacritty-unstable-2018-05-09.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xx8mshil9y63ndbr9inz5lx94xzhfvvs-alacritty-unstable-2018-05-09.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: alacritty

Partial log (click to expand)

shrinking /nix/store/naavp6nvfwv1h0p6lhdrc3jxy28c5dfw-rust_docopt-0.8.1/bin/docopt-wordlist
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/naavp6nvfwv1h0p6lhdrc3jxy28c5dfw-rust_docopt-0.8.1/lib  /nix/store/naavp6nvfwv1h0p6lhdrc3jxy28c5dfw-rust_docopt-0.8.1/bin
patching script interpreter paths in /nix/store/naavp6nvfwv1h0p6lhdrc3jxy28c5dfw-rust_docopt-0.8.1
checking for references to /build in /nix/store/naavp6nvfwv1h0p6lhdrc3jxy28c5dfw-rust_docopt-0.8.1...
cannot build derivation '/nix/store/d7kgazwzbaqqgwwdswm1vpgyqp50mvqk-rust_cargo-0.22.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/jl2mmh0qppppkl3vbimi8aykgjs8fdpx-rust_cargo-vendor-0.1.13.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/f2m00khap98b8sp399r3cysm3y222317-alacritty-unstable-2018-05-09-vendor.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4kfy1diilkj7h6ym9r1a760hzcn767vl-alacritty-unstable-2018-05-09.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/4kfy1diilkj7h6ym9r1a760hzcn767vl-alacritty-unstable-2018-05-09.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: alacritty

Partial log (click to expand)

test src/meter.rs - meter (line 21) ... ok

test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/y5ddf7a99i3ridri9k647cs72c1a273p-alacritty-unstable-2018-05-09/bin
patching script interpreter paths in /nix/store/y5ddf7a99i3ridri9k647cs72c1a273p-alacritty-unstable-2018-05-09
/nix/store/y5ddf7a99i3ridri9k647cs72c1a273p-alacritty-unstable-2018-05-09

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: alacritty

Partial log (click to expand)

   |

warning: unnecessary parentheses around function argument
  --> src/index.rs:82:82
   |
82 | #[derive(Debug, Copy, Clone, Eq, PartialEq, Default, Ord, PartialOrd, Serialize, Deserialize)]
   |                                                                                  ^^^^^^^^^^^ help: remove these parentheses

building of '/nix/store/2laa7v36zs46d47w27wyfinwmbcwm7mi-alacritty-unstable-2018-04-16.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/2laa7v36zs46d47w27wyfinwmbcwm7mi-alacritty-unstable-2018-04-16.drv' failed

@Mic92 Mic92 merged commit 4c132c4 into NixOS:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TravisWhitaker @Mic92 @GrahamcOfBorg