WIP: pythonPackages.ModernGL: init at 5.2.1 #40767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
May 19, 2018
pkgs/top-level/python-packages.nix
Outdated
| mail-parser = callPackage ../development/python-modules/mail-parser { }; | ||
| mail-parser = callPackage ../development/python-modules/mail-parser { }; | ||
|
|
||
| ModernGL = callPackage ../development/python-modules/ModernGL { }; |
There was a problem hiding this comment.
can you make the attribute lowercase
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ModernGL: High performance rendering for Python 3
Still have the tests failing cause of this error:
mgl.Error: cannot detect the displayIt would be great if anyone can help me understand that issue (tried including pyopengl in check input but no good)
The build succeed when disabling the checks.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)