Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "zsh: move setEnvironment stuff to zprofile" #40759

Merged
merged 1 commit into from
May 19, 2018

Conversation

gkleen
Copy link
Contributor

@gkleen gkleen commented May 19, 2018

This reverts commit 77a6cbb.

Motivation for this change

Start of non-interactive, non-login shells (e.g. directly executing commands via ssh) is broken due to missing $PATH.

cfg.shellInit and cfge.shellInit need $PATH, too:

/etc/zshenv:10: command not found: mkdir
/etc/zshenv:11: command not found: stat
/etc/zshenv:11: command not found: id
/etc/zshenv:32: command not found: mkdir
/etc/zshenv:33: command not found: stat
/etc/zshenv:33: command not found: id

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 19, 2018
@xeji xeji merged commit 94afddc into NixOS:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants