mongodb: 3.4.10 -> 4.0.12 #40082
Merged
mongodb: 3.4.10 -> 4.0.12 #40082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build mongodb |
|
Failure on x86_64-darwin (full log) Attempted: mongodb Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: mongodb Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mongodb Partial log (click to expand)
|
obadz
suggested changes
May 12, 2018
|
I don't have access to a mac to test with, but adding |
|
@GrahamcOfBorg build mongodb |
1 similar comment
|
@GrahamcOfBorg build mongodb |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: mongodb Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: mongodb Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: mongodb Partial log (click to expand)
|
|
@GrahamcOfBorg build mongodb |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: mongodb Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: mongodb Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mongodb Partial log (click to expand)
|
|
Hello! @jarjee could you rebase this, or may I make a new PR with your changes? Also, Mongo is no longer supported on 32-bit systems - "Changed in version 3.4: MongoDB no longer supports 32-bit x86 platforms." so I think |
|
Hi @cyounkins, yes I can rebase this PR. I mostly abandoned this PR since I couldn't build on OSX. |
jarjee
force-pushed
the
update/mongodb
branch
from
9da4601
to
71edf6a
Compare
jarjee
force-pushed
the
update/mongodb
branch
from
71edf6a
to
22e9795
Compare
|
It appears the 32-bit issue remains in your most recent push - We need to disable building on 32-bit systems as it isn't supported and in my testing has failed. This is the error that occurs: https://jira.mongodb.org/browse/SERVER-22810 Could you please set |
|
@cyounkins Sorry for the wait, I've made the change you requested. |
|
@GrahamcOfBorg build mongodb |
Ma27
added
the
9.needs: port to stable
|
I would love that. I lost track where we're at with this, though. Are you running with this now @Ma27? |
In |
fix: Adding libtool to allow darwin compiles Libtool seems to be required for mongodb to compile on darwin. fix: Marking MongoDB as broken on aarch64 fix: Adding libtools to the pkg imports Update mongodb to 4.0.4
Now has tests for 3.4, 3.6, 4.0. Has some duplication, but it appears to work on my machine.
Reverts previous ssl fix commit and updates the mongodb version which fixes the ssl compile problem on darwin.
perl-based VM tests are deprecated.
|
I rewrote the test in python, rebased to master and cleaned up the history. As soon as the mongodb builds (and test) I'm running locally are finished, I'll push the changeset and merge :) |
|
@GrahamcOfBorg test mongodb |
|
@GrahamcOfBorg build mongodb-4_0 mongodb-3_4 mongodb-3_6 |
|
@jarjee @worldofpeace @offlinehacker @aanderse can you please take a look at the license (sspl)? According to MongoDB's FAQ it's free, based on GPLv3, but not (yet?) approved by the OSI (https://www.mongodb.com/licensing/server-side-public-license/faq). From my understanding it should be therefore possible to mark The main reason I'm asking is because it takes quite some time and resources to compile I guess one of the most important paragraphs from the FAQ is the following:
|
|
Merging for now. As discussed in |
|
Thanks for this! Any idea if it would take much work to also add mongo 4.2? |
|
Without having it tested: I don't think so, the packages are already splitted, so it should be fairly easy to add another one :) For the record: I didn't forget the backport, I'll file a PR for this tomorrow hoping that I get a bit more feedback on #83433 first :) |
10 tasks
TredwellGit
added
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bringing the mongodb server up to the latest stable release. Also had some odd issues with the JS interpreter when using "load()", which seems to be fixed in this version.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)