Looks good to me. Another idea might be to rename the Path class. I don't really like the name, I think it had another name before and then I saw it in some other language's source code (can't remember if it's Rust or C#).

What other name could we use? A Path right now is basically Foo or Foo::Bar::Baz, something that resolves to a constant.

you could call it a TypePath or NamespacePath... I don't really like either.

TypeName? 😐

I like TypePath. Path is pretty generic (hence the conflict), but TypePath is pretty clear about being a path of types.

@straight-shoota If you want you can tweak this PR to rename Path to TypePath, though I think it will conflict with #6063, so it might be better to merge that one first.

That should probably better be a new PR because it's a completely different solution.

Anyway, it's not super urgent because #5635 probably needs quite some work before that. So it's no deal to wait if hopefully #6063 can get merged soon.

@asterite can't a TypePath be a path to a constant though? ::Foo::Bar::CONSTANT is parsed as a Path right?

@RX14 That's correct. But a constant is represented internally as a type too 😛

OK, sounds fine to me then

I think this is fine as it is 👍 @straight-shoota can you rebase?

Rebased

needs a format