Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graylog: 2.4.3 -> 2.4.4 #40133

Merged
merged 2 commits into from May 10, 2018
Merged

graylog: 2.4.3 -> 2.4.4 #40133

merged 2 commits into from May 10, 2018

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented May 7, 2018

Motivation for this change

https://www.graylog.org/post/announcing-graylog-v2-4-4

includes security fix, please cherry-pick to release-18.03 馃檪

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 7, 2018

@GrahamcOfBorg build graylog

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: graylog

Partial log (click to expand)

shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-amd64-solaris.so
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-x86-freebsd-5.so
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-x86-solaris.so
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-ia64-hpux-11.sl
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-ia64-linux.so
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-sparc-solaris.so
patching script interpreter paths in /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4
/nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/bin/graylogctl: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4...
/nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: graylog

Partial log (click to expand)

shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-amd64-linux.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-s390x-linux.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-ppc64-linux.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-sparc64-solaris.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-x86-freebsd-6.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-x86-linux.so
patching script interpreter paths in /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4
/nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/bin/graylogctl: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4...
/nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: graylog

Partial log (click to expand)

source root is graylog-2.4.4
setting SOURCE_DATE_EPOCH to timestamp 1525264957 of file graylog-2.4.4/plugin/graylog-plugin-threatintel-2.4.4.jar
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/jrgvwg5an63b5zss924rcvndixvcf9vf-graylog-2.4.4
/nix/store/jrgvwg5an63b5zss924rcvndixvcf9vf-graylog-2.4.4/bin/graylogctl: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/jrgvwg5an63b5zss924rcvndixvcf9vf-graylog-2.4.4

@xeji
Copy link
Contributor

xeji commented May 7, 2018

This package is missing a runtime dependency on jre:

$ ./graylogctl 
which: no java in (/home/xxx/bin:/home/xxx/bin:/run/wrappers/bin:/etc/profiles/per-user/xxx/bin:/home/xxx/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin)

Apparently graylogctl needs a wrapper with JAVA_HOME set to ${jre}.

@xeji
Copy link
Contributor

xeji commented May 8, 2018

@GrahamcOfBorg build graylog

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: graylog

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: graylog

Partial log (click to expand)

shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-sparc64-solaris.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-amd64-freebsd-6.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-ppc-linux.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-ia64-linux.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-x86-freebsd-5.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-x86-solaris.so
patching script interpreter paths in /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4
/nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/bin/.graylogctl-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4...
/nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: graylog

Partial log (click to expand)

source root is graylog-2.4.4
setting SOURCE_DATE_EPOCH to timestamp 1525264957 of file graylog-2.4.4/plugin/graylog-plugin-threatintel-2.4.4.jar
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/a6qlhmbcb9br8siws5x0cqminsgnvhjx-graylog-2.4.4
/nix/store/a6qlhmbcb9br8siws5x0cqminsgnvhjx-graylog-2.4.4/bin/.graylogctl-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/a6qlhmbcb9br8siws5x0cqminsgnvhjx-graylog-2.4.4

@xeji
Copy link
Contributor

xeji commented May 8, 2018 

result/bin/graylogctl start
Starting graylog-server ...
/nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/bin/.graylogctl-wrapped: line 60: log/graylog-server.log: No such file or directory

Is the default LOG_FILE=${LOG_FILE:=log/graylog-server.log} intended to be a relative path? This fails if the log directory doesn't exist.

@fadenb
graylog: 2.4.3 -> 2.4.4
08eba84
@fadenb
graylog: wrap graylogctl
9817b4a 
Wrapper ensures graylogctl script can find java
@fadenb
Copy link
Contributor Author

fadenb commented May 10, 2018

@xeji: can we merge this anyway?
It has been this way since Graylog was included in nixpkgs. On NixOS is is not an issue as Graylog is usually used via the Graylog module.

If you feel strongly about it I will create a separate issue tracking this.

@xeji
Copy link
Contributor

xeji commented May 10, 2018

No problem, let's leave this as is if it doesn't hurt.

@xeji xeji merged commit 7028dcd into NixOS:master May 10, 2018
@fadenb fadenb deleted the graylog_2.4.4 branch May 13, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fadenb @xeji @GrahamcOfBorg