support S3 multipart uploads for large NARs #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
case the nix command is interrupted.
edolstra
reviewed
May 7, 2018
| if (contentEncoding != "") | ||
| request.SetContentEncoding(contentEncoding); | ||
| auto executor = | ||
| std::make_shared<Aws::Utils::Threading::PooledThreadExecutor>(maxThreads); |
There was a problem hiding this comment.
This thread pool should be shared between invocations, otherwise e.g. nix copy will start cores^2 threads (since it will do multiple copies in parallel). E.g.
static std::make_shared<Aws::Utils::Threading::PooledThreadExecutor> = std::make_shared<...>(maxThreads);
There was a problem hiding this comment.
@edolstra I pushed a fix in case you missed it :)
edolstra
reviewed
May 7, 2018
| printTalkative("upload progress ('%s'): '%d' of '%d' bytes", | ||
| path, | ||
| transferHandle->GetBytesTransferred(), | ||
| transferHandle->GetBytesTotalSize()); |
There was a problem hiding this comment.
This looks like it could really spam the console. It should use Nix's progress API.
There was a problem hiding this comment.
I guess it's fine since it requires -v.
There was a problem hiding this comment.
yeah it's only when you specify a higher debug level, not sure how many v's though :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.