nixos/release-combined.nix: make test set consistent with release-small.nix #40131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... with release-small.nix Tests for small channel should be a subset of tests for full channel.
|
👍 looks good! One thing I’m intereated in is if we can just concat the small releases jobs in combined? That would automate this process for us. |
Should be possible with a little refactoring. release-combined.nix maps tests over supportedSystems like this: |
|
Importing a common list for a separate file sounds sane. :) |
vcunat
approved these changes
May 8, 2018
vcunat
added
the
9.needs: port to stable
xeji
added a commit
that referenced
this pull request
May 10, 2018
... with release-small.nix Tests for small channel should be a subset of tests for full channel. (cherry picked from commit f8d047d)
|
backported to 18.03 in e5be49a |
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tests for the "small" NixOS channel should be a subset of tests for the full "release" channel so these channels advance consistently. Currently, the small channel can be blocked while the full channel advances, which does not make much sense.
Fix this by adding some tests to
release-combined.nixthat previously were only inrelease-small.nix.(Eventually the common "small" subset of tests should be factored out to force consistency but I'll save that for another time.)
cc @srhb @vcunat