Background

It's possible for a mod with an incompatible dependency to be presented as compatible in GUI, as long as this dependency is more than one step away (i.e., a dependency of a dependency). For example, in KSP 1.4.2 currently, AJE Extended depends on AJE, which depends on FAR, which isn't compatible. So FAR and AJE are properly marked as incompatible, but AJE Extended is treated as compatible. This is covered by #2231 and not fixed here.

Problem

After you check such an incompatible checkbox, you'll get the error popup about it every time you click any other checkbox, until you uncheck the incompatible one.

Cause

The only action we took in response to this condition was to raise an error message. This may partly be because we were catching ModuleNotFoundKraken, which doesn't indicate the depending module.

Changes

Now we catch DependencyNotSatisfiedKraken (which inherits from ModuleNotFoundKraken and is the actual type of the exception already being thrown) and use its parent property to find the mod with the incompatible dependency, and uncheck it with MarkModForInstall. This unchecks the problematic module, so further selections may be made without seeing the same error message over and over.

Note that this only covers missing dependencies, and not any other sort of conflict. Unlike a mod-to-mod conflict, a mod with a missing dependency can never be installed, so there is no value in keeping it selected because there is no other way to solve the problem other than deselecting it.

Simply setting the Value property of the right cell resulted in a glitchy UI; the checkbox still appeared to be checked until the user took another action on the grid, such as clicking anywhere within it, at which time the checkbox's true unchecked state was drawn. We now call RefreshEdit and Refresh on the grid after setting a cell value to work around this.

Fixes #2419.