Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: Set PERL_PATH when building manual #39453

Merged
merged 1 commit into from Apr 24, 2018
Merged

git: Set PERL_PATH when building manual #39453

merged 1 commit into from Apr 24, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Apr 24, 2018

Otherwise the build fails with the perplexing error

make: *** No rule to make target 'cmd-list.made', needed by 'doc.dep'.  Stop.
make: Leaving directory '/tmp/nix-build-git-2.16.3.drv-0/git-2.16.3/Documentation'

on NixOS (but not on Debian, where it succeeds, presumably since it picks up the
system perl).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bgamari
git: Set PERL_PATH when building manual
b26ae50 
Otherwise the build fails with the perplexing error

    make: *** No rule to make target 'cmd-list.made', needed by 'doc.dep'.  Stop.
    make: Leaving directory '/tmp/nix-build-git-2.16.3.drv-0/git-2.16.3/Documentation'

on NixOS (but not on Debian, where it succeeds, presumably since it picks up the
system perl).
@bgamari
Copy link
Contributor Author

bgamari commented Apr 24, 2018

This builds on NixOS (cross-compiled and otherwise) and Debian, unlike the original patch.

@dtzWill
Copy link
Member

dtzWill commented Apr 24, 2018

Merging to fix building git. (Thanks!!)

@dtzWill dtzWill merged commit de40a77 into NixOS:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @dtzWill @GrahamcOfBorg