Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: 2.16.3 -> 2.17.0, again, installCheck #39461

Merged
merged 2 commits into from Apr 26, 2018
Merged

git: 2.16.3 -> 2.17.0, again, installCheck #39461

merged 2 commits into from Apr 26, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 25, 2018

installCheck work from #38924.

Wowza, what a ride.

Wouldn't mind some eyes on this to spot anything missed,
let's get this right and move onwards! :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: git

Partial log (click to expand)

All tests successful.
Files=801, Tests=18583, 372 wallclock secs ( 4.34 usr  0.95 sys + 256.52 cusr 255.69 csys = 517.50 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.17.0/t'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.17.0/t'
make[1]: Leaving directory '/build/git-2.17.0/t'
/nix/store/c9czw03iykw9x3lmfcrskrnbrk10mzhc-git-2.17.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: git

Partial log (click to expand)

All tests successful.
Files=801, Tests=18583, 201 wallclock secs (83.98 usr 17.28 sys + 2733.11 cusr 7267.83 csys = 10102.20 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.17.0/t'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.17.0/t'
make[1]: Leaving directory '/build/git-2.17.0/t'
/nix/store/23v6j66d6al5yqqqch5fvp6kr43q3lfa-git-2.17.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: git

Partial log (click to expand)

cannot build derivation '/nix/store/vwwg2vxbfzrlafw1n98015rgadb8dg21-configd-osx-10.8.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/d7ijs5kcrx20skw1s8b3bw091nmwk9h7-python-2.7.14.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/nwaqkzdy95nh7dr5x83pi4qahv5rrb22-asciidoc-8.6.9.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/pi46npb38bjzl7kc7k4vmghipq113qkl-libxml2-2.9.8.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hgscf1rgzz7apjybpsyg0bf26dx4s9vg-libxslt-1.1.32.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/9vbb0bzvbi44nfmgplsvg1iq9zv4r948-xmlto-0.0.28.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/h02ddjanzcjfqxzn9wxj4h9xvvpjx9yf-opensp-1.5.2.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/v2gslcs158l2cgiq5wq32vi9dkhrdmc4-docbook2X-0.8.8.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/02qqqands456sqnck7svja3hcszs821r-git-2.17.0.drv': 23 dependencies couldn't be built
error: build of '/nix/store/02qqqands456sqnck7svja3hcszs821r-git-2.17.0.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2018

Welp looks good to me, let's see how it does on staging.

@dtzWill dtzWill merged commit 6e623fb into NixOS:staging Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @layus