Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfs-utils, tcp_wrappers, libnfsidmap: cleanup, fix w/musl #39448

Merged
merged 4 commits into from Apr 26, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 24, 2018

Replaces previous PR's for these on master.

Can't build nfs-utils on this branch just yet
until systemd bits are upstreamed.

Testing done on branch with those fixes.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Apr 24, 2018

Darwin failure (borg reported it on other PR) for libnfsidmap already occurs: https://hydra.nixos.org/build/72731161/nixlog/1 .

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libnfsidmap, nfs-utils

Partial log (click to expand)

shrinking /nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1/bin/mount.nfs
shrinking /nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1/bin/nfsdcltrack
shrinking /nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1/etc/systemd/system-generators/nfs-server-generator
gzipping man pages under /nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1/share/man/
strip is /nix/store/65ir27a74jycbnjfn1w6n5z701js27di-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1/bin
patching script interpreter paths in /nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1
/nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1/bin/start-statd: interpreter directive changed from "/bin/sh" to "/nix/store/67jl332fgxr2yi7cw1hjxjsvi9znsl53-bash-4.4-p19/bin/sh"
/nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1/bin/osd_login: interpreter directive changed from "/bin/bash" to "/nix/store/67jl332fgxr2yi7cw1hjxjsvi9znsl53-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1...

@dtzWill
Copy link
Member Author

dtzWill commented Apr 24, 2018

FWIW there's a newer nfs-utils version but I had trouble making it work properly so I suppose that'll be a problem for another day :).

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libnfsidmap

The following builds were skipped because they don't evaluate on x86_64-darwin: nfs-utils

Partial log (click to expand)

cannot build derivation '/nix/store/7b0p1a9dqn1dk0i67sy87mvizk9xyrmc-hook.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/q500dd5l84zrj0hw0jm9y4n6dak2sd3h-ICU-osx-10.10.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/rdbzgs9cmklpzk18cd49ij88pb1mixyc-cctools-binutils-darwin.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/x2yj5y9nb4bjr87b27vfpd13safcghaj-gnutar-1.30.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/q2zzmkl4zcvl9k8hihks9k0qjw8i9cnw-CF-osx-10.10.5.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/1j384dcqvb1x1vhf11lrfid6jxanf6p6-cctools-binutils-darwin-wrapper.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/8ii2lppgg70ss83jz3pgdkqfnnz10r0w-clang-wrapper-5.0.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/v8mqjfhxh2vz1m9gd6mc9s5v4w69rlcq-stdenv-darwin.drv': 35 dependencies couldn't be built
cannot build derivation '/nix/store/h688c1vq7d0szs3sag74306s9bmnpkl3-libnfsidmap-0.25.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/h688c1vq7d0szs3sag74306s9bmnpkl3-libnfsidmap-0.25.drv' failed

@dtzWill dtzWill force-pushed the fix/nfs-bits-cleanup-and-musl branch from 0f2efe4 to 3e1f698 Compare April 24, 2018 23:30
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libnfsidmap, nfs-utils

Partial log (click to expand)

/nix/store/4dswwxm6z203pjz8rmasjbdpwhynjsmf-libnfsidmap-0.25
/nix/store/rhqvl3idv9y2id68d2ymq0rbcpmbxp0f-nfs-utils-2.1.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libnfsidmap, nfs-utils

Partial log (click to expand)

shrinking /nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1/bin/rpcdebug
gzipping man pages under /nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1/share/man/
strip is /nix/store/g6ppn3cjscxg0jw5wcnc7413wwx1fn77-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1/bin
patching script interpreter paths in /nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1
/nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1/bin/osd_login: interpreter directive changed from "/bin/bash" to "/nix/store/njrnxg4wvqkfz2qfrxqyrac5lsq5q1jr-bash-4.4-p19/bin/bash"
/nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1/bin/start-statd: interpreter directive changed from "/bin/sh" to "/nix/store/njrnxg4wvqkfz2qfrxqyrac5lsq5q1jr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1...
/nix/store/qh5pczmmcf5rb4yim0m88aq518vaakn5-libnfsidmap-0.25
/nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libnfsidmap, nfs-utils

Partial log (click to expand)

these derivations will be built:
  /nix/store/0jpckfqy82zwz7p5bbjl6vnd6mqkpik4-gnutls-3.6.2.drv
  /nix/store/i2jvxjjq6vnd04p3ym5aszkvhrmidpzz-libmicrohttpd-0.9.59.drv
  /nix/store/5yjy1fcqbdxnl6halvmfkpr12qqnj8hx-systemd-238.drv
  /nix/store/bn520wxpbianpw4lx7g04ph8mvc169d4-util-linux-2.31.1.drv
  /nix/store/dh51impz41apd76q6gqr7321p2257xz1-lvm2-2.02.177.drv
  /nix/store/gcg4bzi5fhv7s6j6w1349bzmyp2ih8hx-nfs-utils-2.1.1.drv
waiting for locks or build slots...
/nix/store/qh5pczmmcf5rb4yim0m88aq518vaakn5-libnfsidmap-0.25
/nix/store/z83x9d1hhbzs9jwsw4fnzx3i0jksjksv-nfs-utils-2.1.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libnfsidmap

The following builds were skipped because they don't evaluate on x86_64-darwin: nfs-utils

Partial log (click to expand)

cannot build derivation '/nix/store/7b0p1a9dqn1dk0i67sy87mvizk9xyrmc-hook.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/q500dd5l84zrj0hw0jm9y4n6dak2sd3h-ICU-osx-10.10.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/rdbzgs9cmklpzk18cd49ij88pb1mixyc-cctools-binutils-darwin.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/x2yj5y9nb4bjr87b27vfpd13safcghaj-gnutar-1.30.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/q2zzmkl4zcvl9k8hihks9k0qjw8i9cnw-CF-osx-10.10.5.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/1j384dcqvb1x1vhf11lrfid6jxanf6p6-cctools-binutils-darwin-wrapper.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/8ii2lppgg70ss83jz3pgdkqfnnz10r0w-clang-wrapper-5.0.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/v8mqjfhxh2vz1m9gd6mc9s5v4w69rlcq-stdenv-darwin.drv': 35 dependencies couldn't be built
cannot build derivation '/nix/store/h688c1vq7d0szs3sag74306s9bmnpkl3-libnfsidmap-0.25.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/h688c1vq7d0szs3sag74306s9bmnpkl3-libnfsidmap-0.25.drv' failed

@dtzWill dtzWill merged commit f54d54d into NixOS:staging Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants