Remove dependency on libxml from spec runner #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
jm/feature/spec-remove-libxml-dep
branch
from
225e756
to
48ce17c
Compare
asterite
approved these changes
Apr 25, 2018
bew
reviewed
Apr 25, 2018
src/spec/junit_formatter.cr
Outdated
| end | ||
| io << %(">) |
There was a problem hiding this comment.
If there is no message there is no " to add
RX14
requested changes
Apr 26, 2018
src/spec/junit_formatter.cr
Outdated
| end | ||
| # -------- private utility methods | ||
| private def write_report(result, io) | ||
| io << %( <testcase file=") << result.file |
src/spec/junit_formatter.cr
Outdated
| # -------- private utility methods | ||
| private def write_report(result, io) | ||
| io << %( <testcase file=") << result.file | ||
| io << %(" classname=") << classname(result) << %(" name=") |
RX14
approved these changes
Apr 26, 2018
This was referenced Apr 26, 2018
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
* Revert "Change spec junit formatter to use XML::Builder" This reverts commit 5957f02. * Improve output of JUnit formatter and simplify implementation This re-applies the formatting of XML::Builder from 5957f02 without the dependency on libxml. * fixup! Improve output of JUnit formatter and simplify implementation * fixup! Improve output of JUnit formatter and simplify implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the implementation of #4090 but modifies the plain string formatter to produce the same, indented output as
XML::Builder. This avoids having all specs depend onlibxmlwhile still enabling JUnit formatter.Closes #5662