matterbridge module: add configPath option as a workaround, waiting for nix encryption #39455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekleog
force-pushed
the
matterbridge-configfile
branch
from
b38f6d5
to
4cc34a0
Compare
…or nix encryption
Ekleog
force-pushed
the
matterbridge-configfile
branch
from
4cc34a0
to
e199143
Compare
|
For easy review, the diff is unexpectedly big due to my removing a useless mkMerge, which reduces indentation and generates a diff. The only real changes in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Waiting for NixOS/rfcs/pull/5 , files including secrets should not be set in the nix store, so adding a configPath option as workaround.
I've tested this PR with
nixos-rebuildandnix-diff: with the same configuration, absolutely no change happens (apart from the nixos-version hash change). WithconfigPathset, the parameter appears to be properly set.I think that, as a security fix, this deserves backport to 18.03.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)