fetchFromGitLab: Use API archive download endpoint. #39467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://gitlab.com/gitlab-org/gitlab-ce/issues/45586#note_69828451 this URL is something with guaranteed stability.
8 tasks
|
Yes and no. It is necessary to write it as %2F for gitlab.com's api. The difference is, written as %2F it doesn't count as path separator of the URL but as a character of the path component. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://gitlab.com/gitlab-org/gitlab-ce/issues/45586#note_69828451
this URL is something with guaranteed stability.
Motivation for this change
Trying to get the "officially" correct archive download URL for gitlab.com
Things done
As this doesn't change any hashes, it doesn't trigger any rebuilds and is hard to test.
I manually tried it for procps-ng and checked that the downloaded archive doesn't differ from
a checked out clone of the specified repository.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)