stdenv: better names for cc and bintools #39458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: gcc Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gcc Partial log (click to expand)
|
|
Thanks! It was quite ugly before. Just one thing: Multi-target compilers like clang need single-target wrappers, so the wrappers need to atleast add the target if one isn't already there. (Make sure not to make Probably also good to change GCC so it also has a targetPrefix attribute for consistency. |
oxij
force-pushed
the
stdenv/beautifications
branch
from
f0978cc
to
5603d96
Compare
|
Fixed.
Too lazy :) |
... binutils and gcc add it already anyway. Without this it's easy to get cross-toolchain paths longer than 256 chars and nix-daemon will then fail to commit them to /nix/store on XFS.
oxij
force-pushed
the
stdenv/beautifications
branch
from
5603d96
to
43dbc26
Compare
|
Success on aarch64-linux (full log) Attempted: gcc Partial log (click to expand)
|
Acceptable :) |
Ericson2314
approved these changes
Apr 26, 2018
|
Success on x86_64-linux (full log) Attempted: gcc Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Mostly beautification, but with a long
crossSystem.configI managed to breaknix-buildon XFS without this. See commit messages.Things done