Fix CI (Kernel#exit always exits with 0 code, chrome runner exits wit…

…h 0 if chrome wasn't started). (#1807)
opal · Apr 20, 2018 · dbec19c · dbec19c
1 parent b6bf799
commit dbec19c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,6 +1,6 @@
 language: ruby
 
-sudo: false
+sudo: required
 
 dist: trusty
 
@@ -95,6 +95,9 @@ before_install:
   - which google-chrome-stable
   - google-chrome-stable --version
   - export RUBYOPT=-w
+  # Wokraround from https://github.com/travis-ci/travis-ci/issues/9024#issuecomment-356282802
+  - sudo chown root /opt/google/chrome/chrome-sandbox
+  - sudo chmod 4755 /opt/google/chrome/chrome-sandbox
 
 script:
   - "bundle exec rake $RUN"

diff --git a/lib/opal/cli_runners/chrome.rb b/lib/opal/cli_runners/chrome.rb
@@ -73,6 +73,7 @@ def run_chrome_server
       rescue Timeout::Error
         puts 'Failed to start chrome server'
         puts 'Make sure that you have it installed and that its version is > 59'
+        exit(1)
       ensure
         Process.kill('HUP', chrome_pid) if chrome_pid
       end

diff --git a/opal/corelib/kernel.rb b/opal/corelib/kernel.rb
@@ -191,7 +191,7 @@ def exit(status = true)
         status = 0
       } else if (status.$$is_boolean) {
         status = status ? 0 : 1;
-      } else if (status.$$is_numeric) {
+      } else if (status.$$is_number) {
         status = status.$to_i();
       } else {
         status = 0