Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eff: 20140928 -> 5.0 #39264

Merged
merged 2 commits into from Apr 23, 2018
Merged

eff: 20140928 -> 5.0 #39264

merged 2 commits into from Apr 23, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 20, 2018

Motivation for this change

Update to a released version.

Note that two tests fail, but that seems expected. This has been recently fixed upstream (matijapretnar/eff@be7442d) but not released yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eff

Partial log (click to expand)

install flags: install SHELL=/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash
ocaml setup.ml -install
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d5pskx2s9gac39kn31n1jj04fc82gvg3-eff-5.0
shrinking /nix/store/d5pskx2s9gac39kn31n1jj04fc82gvg3-eff-5.0/bin/eff
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d5pskx2s9gac39kn31n1jj04fc82gvg3-eff-5.0/bin
patching script interpreter paths in /nix/store/d5pskx2s9gac39kn31n1jj04fc82gvg3-eff-5.0
checking for references to /build in /nix/store/d5pskx2s9gac39kn31n1jj04fc82gvg3-eff-5.0...
/nix/store/d5pskx2s9gac39kn31n1jj04fc82gvg3-eff-5.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: eff

Partial log (click to expand)

cannot build derivation '/nix/store/c1r0z54kykvrxvy26hccdbpzarbfd6x2-ocaml4.05.0-ocaml-migrate-parsetree-1.0.7.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/kmb8y6gal35pfr42c8ssm5vr4na6sfm5-ocaml4.05.0-topkg-0.9.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/3m87k6lw68yrwj0iszx5gmsby6p42ijz-ocaml4.05.0-uchar-0.0.2.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/xd05f4fy608bk2dmxpvs3z679iani8bm-ocaml-cmdliner-1.0.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/zicm2y0m5gl151p63qv4w8ndryyy6l3d-ocaml-ppx_tools_versioned-5.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/rikv8lv2ln4dhxxmcfkhks5h1b16b7a8-ocaml4.05.0-yojson-1.4.1.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/iq1ibing1scpfsaw7j2zh92whslk9b4f-js_of_ocaml-compiler-3.1.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/h32vrfmam1dak3iy5qsq8lhn4qskkcih-js_of_ocaml-3.1.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/y2a5r1lrjl468bngl8aw1b2g1n92rr1l-eff-5.0.drv': 6 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/y2a5r1lrjl468bngl8aw1b2g1n92rr1l-eff-5.0.drv' failed

@Mic92
Copy link
Member

Mic92 commented Apr 21, 2018 •
edited

Tests fixes can be backported with fetchPatch from github if necessary.

Mic92
Mic92 reviewed Apr 21, 2018
View reviewed changes
pkgs/development/interpreters/eff/default.nix Outdated
url = "https://github.com/matijapretnar/eff.git";
rev = "90f884a790fddddb51d4d1d3b7c2edf1e8aabb64";
sha256 = "0cqqrpvfw0nrk5d28mkzfvc8yzqxcss0k46bkmqhqjkqq886n2mm";
src = fetchzip {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchFromGithub maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has the same semantics, but is it is mainly about consistency with the code base. We also have some tooling that looks for fetchFromGithub and interfere additional information.

@vbgl
Copy link
Contributor Author

vbgl commented Apr 23, 2018

Updated to use fetchFromGitHub.

I don’t think the tests need fixing: their failure shows a problem with the tests, not with the software under test.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eff

Partial log (click to expand)

/nix/store/d5pskx2s9gac39kn31n1jj04fc82gvg3-eff-5.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: eff

Partial log (click to expand)

cannot build derivation '/nix/store/c1r0z54kykvrxvy26hccdbpzarbfd6x2-ocaml4.05.0-ocaml-migrate-parsetree-1.0.7.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/kmb8y6gal35pfr42c8ssm5vr4na6sfm5-ocaml4.05.0-topkg-0.9.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/3m87k6lw68yrwj0iszx5gmsby6p42ijz-ocaml4.05.0-uchar-0.0.2.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/xd05f4fy608bk2dmxpvs3z679iani8bm-ocaml-cmdliner-1.0.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/zicm2y0m5gl151p63qv4w8ndryyy6l3d-ocaml-ppx_tools_versioned-5.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/rikv8lv2ln4dhxxmcfkhks5h1b16b7a8-ocaml4.05.0-yojson-1.4.1.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/iq1ibing1scpfsaw7j2zh92whslk9b4f-js_of_ocaml-compiler-3.1.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/h32vrfmam1dak3iy5qsq8lhn4qskkcih-js_of_ocaml-3.1.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/y2a5r1lrjl468bngl8aw1b2g1n92rr1l-eff-5.0.drv': 6 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/y2a5r1lrjl468bngl8aw1b2g1n92rr1l-eff-5.0.drv' failed

@Mic92 Mic92 merged commit 5f82c32 into NixOS:master Apr 23, 2018
@vbgl vbgl deleted the eff-5.0 branch April 23, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @Mic92