Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlib: 19.9 -> 19.10 #39255

Closed
wants to merge 1 commit into from
Closed

dlib: 19.9 -> 19.10 #39255

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/dlib/versions.

These checks were done:

  • built on NixOS
  • Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
  • found 19.10 with grep in /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10
  • directory tree listing: https://gist.github.com/227f969f6d6122a323fabf28fff29dd7

cc @christopherpoole for review

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/dlib/versions.

These checks were done:

- built on NixOS
- Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
- found 19.10 with grep in /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10
- directory tree listing: https://gist.github.com/227f969f6d6122a323fabf28fff29dd7
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dlib

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dlib

Partial log (click to expand)

-- Installing: /nix/store/gbvhqvgfncin1fdkv5v49v6szwykv7hi-dlib-19.10/lib/cmake/dlib/dlibConfig.cmake
-- Installing: /nix/store/gbvhqvgfncin1fdkv5v49v6szwykv7hi-dlib-19.10/lib/cmake/dlib/dlibConfigVersion.cmake
-- Installing: /nix/store/gbvhqvgfncin1fdkv5v49v6szwykv7hi-dlib-19.10/lib/pkgconfig/dlib-1.pc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gbvhqvgfncin1fdkv5v49v6szwykv7hi-dlib-19.10
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gbvhqvgfncin1fdkv5v49v6szwykv7hi-dlib-19.10/lib
patching script interpreter paths in /nix/store/gbvhqvgfncin1fdkv5v49v6szwykv7hi-dlib-19.10
checking for references to /build in /nix/store/gbvhqvgfncin1fdkv5v49v6szwykv7hi-dlib-19.10...
/nix/store/gbvhqvgfncin1fdkv5v49v6szwykv7hi-dlib-19.10

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dlib

Partial log (click to expand)

-- Installing: /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10/lib/cmake/dlib/dlib-release.cmake
-- Installing: /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10/lib/cmake/dlib/dlibConfig.cmake
-- Installing: /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10/lib/cmake/dlib/dlibConfigVersion.cmake
-- Installing: /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10/lib/pkgconfig/dlib-1.pc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10/lib
patching script interpreter paths in /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10
checking for references to /build in /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10...

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.face_recognition python3.pkgs.face_recognition

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.face_recognition, python3.pkgs.face_recognition

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.5.0, py-1.5.3, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 66 items

tools/python/test/test_array.py ..............                           [ 21%]
tools/python/test/test_global_optimization.py /nix/store/3y0wxpkxzs6yz73iw35d17qr1wp4p2i4-stdenv-linux/setup: line 1223:  2979 Segmentation fault      /nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/bin/python3.6m nix_run_setup test
builder for '/nix/store/zcijgl4nb15zkkxsamkdkqrwgvn456sy-python3.6-dlib-19.10.drv' failed with exit code 139
cannot build derivation '/nix/store/pwli43i2vxpdxznipy2lsizvb90h1qa6-python3.6-face_recognition-1.2.2.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/cbd3q24s3x9pr0b8lsai970z834myv4s-python2.7-face_recognition-1.2.2.drv', '/nix/store/pwli43i2vxpdxznipy2lsizvb90h1qa6-python3.6-face_recognition-1.2.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.face_recognition, python3.pkgs.face_recognition

Partial log (click to expand)

============================= test session starts ==============================
platform linux2 -- Python 2.7.14, pytest-3.5.0, py-1.5.3, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 66 items

tools/python/test/test_array.py ..............                           [ 21%]
tools/python/test/test_global_optimization.py /nix/store/9vknvj1gnbd2mbci7sw07cy1lgyxxy02-stdenv-linux/setup: line 1223:  3061 Segmentation fault      /nix/store/pmsj5p5hj9ylj9lnpd0n1vr37m6kl4sa-python-2.7.14/bin/python2.7 nix_run_setup test
builder for '/nix/store/kchjrpkz2gjy1ng23gxrvhnr7agzhxl4-python2.7-dlib-19.10.drv' failed with exit code 139
cannot build derivation '/nix/store/qym3z680adk3h6mqag5ipykdjqmffk1z-python2.7-face_recognition-1.2.2.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/qmqa6zrak1r4rxgw58w0hffwklkb1ncp-python3.6-face_recognition-1.2.2.drv', '/nix/store/qym3z680adk3h6mqag5ipykdjqmffk1z-python2.7-face_recognition-1.2.2.drv' failed

@Mic92
Copy link
Member

Mic92 commented Apr 21, 2018

Build failures looks serious. Someone should check first if it is related to this update.

@dotlambda
Copy link
Member

Maybe @Ma27 can have a look.

@Ma27
Copy link
Member

Ma27 commented Apr 23, 2018

thx for the notification, I can have a look at it tonight %)

@Ma27
Copy link
Member

Ma27 commented Apr 23, 2018

@dotlambda @Mic92 the last time @ryantm attempted a package bump the same thing happened (and dlib 19.9 on nixpkgs master works perfectly fine).

IIRC @dotlambda did some investigation and found the patch which caused the issue. However I somehow forgot about this (sorry :/). In the end I'd keep this on hold until we managed to fix the build errors related to dlib. I may have a look at this tonight, but I'm not sure though....

@Ma27
Copy link
Member

Ma27 commented Apr 25, 2018

I'm quite sure that this the broken tests are realated to nixpkgs. I tried to run the tests in the following docker container and it worked fine:

FROM python:3

RUN apt-get update && apt-get install -y cmake libopenblas-dev libpng-dev libjpeg-dev git
RUN pip install pytest

RUN git clone https://github.com/davisking/dlib /build-env
WORKDIR /build-env

RUN python setup.py test

However when I clone dlib to my machine (currently 18.03.132008.ad771371fb2 (Impala)) and open a nix shell with the project's dependencies, I can reproduce the segfault.

I'm not yet sure what the cause is, but I suspect that it's some kind of incompatibility between several libraries. However I'll be busy today, I surely hope to do some furhter investigation tonight though :-)

@dotlambda
Copy link
Member

It seems like something similar is happening e.g. here: https://hydra.nixos.org/build/72836676/nixlog/1
@FRidh should also have a look.

@Ma27
Copy link
Member

Ma27 commented Apr 26, 2018

It seems as the commit 9691c194 (which introduces variadic function support for dlib.find_{max,min}_global) causes the segmentation fault.

However I don't know enough about our current Python setup in nixpkgs and this is obviously related to nixpkgs, so it would be indeed quite helpful if @FRidh or @dotlambda could continue investigating :-)

Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Jun 13, 2018
This fixes the latest `dlib` build for `nixpkgs` compliancy:

* Patched `setup.py` to use number of jobs defined in `$NIX_BUILD_CORES`
  rather than using all available cores.

* Bumped `dlib` to latest version (v19.13 ATM).

* Dropped `openblas` build input, `cblas` which actually works lives in
  `dlib/external`. Otherwise the test suite runs into segfaults (see
  NixOS#39255 (comment) for
  further reference).

* Added myself as maintainer in case of any further breakage in the
  future.

Closes NixOS#39255

/cc @dotlambda @ryantm
@Ma27 Ma27 mentioned this pull request Jun 13, 2018
8 tasks
@xeji xeji closed this in #41953 Jun 17, 2018
xeji pushed a commit that referenced this pull request Jun 17, 2018
This fixes the latest `dlib` build for `nixpkgs` compliancy:

* Patched `setup.py` to use number of jobs defined in `$NIX_BUILD_CORES`
  rather than using all available cores.

* Bumped `dlib` to latest version (v19.13 ATM).

* Dropped `openblas` build input, `cblas` which actually works lives in
  `dlib/external`. Otherwise the test suite runs into segfaults (see
  #39255 (comment) for
  further reference).

* Added myself as maintainer in case of any further breakage in the
  future.

Closes #39255

/cc @dotlambda @ryantm
@r-ryantm r-ryantm deleted the auto-update/dlib branch September 6, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants