#39225 - added fix for zfs dracut support #39574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 26, 2018
|
|
||
| # Add modprobe zfs if missing () | ||
| if ! grep --quiet 'modprobe zfs' $(out)/lib/dracut/90zfs/mount-zfs.sh; then | ||
| sed -i '/udevadm settle/s/^/modprobe zfs 2>\/dev\/null&\n/' $(out)/lib/dracut/90zfs/mount-zfs.sh |
There was a problem hiding this comment.
How does this fix NixOS? We are not using dracut.
|
Ah - wasn't aware of that. Only started learning NixOs yesterday. I'll cancel this PR. |
|
The module was also loaded in initrd as far as I remember. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Resolves issue with ZFS not being detected properly by dracut. (#39225)
Issue was created upstream in openzfs/zfs#7287 and resolved later in tonyhutter/zfs@d565bda
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)