Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: 0.11.1 -> 0.12.0 #39585

Merged
merged 1 commit into from May 8, 2018
Merged

bazel: 0.11.1 -> 0.12.0 #39585

merged 1 commit into from May 8, 2018

Conversation

benbarclay
Copy link
Contributor

Motivation for this change

Need an updated version for a project that I'm contributing to.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I've tested this locally in the build process for a project I'm working on, and it seems to work okay.

@Mic92
Copy link
Member

Mic92 commented Apr 27, 2018

cc @rbvermaa

@zimbatm
Copy link
Member

zimbatm commented May 8, 2018

@GrahamcOfBorg build bazel

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bazel

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bazel

Partial log (click to expand)

//examples/cpp:hello-success_test                                        PASSED in 0.1s
//examples/java-native/src/test/java/com/example/myproject:hello         PASSED in 0.5s

Executed 2 out of 2 tests: 2 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
installing
post-installation fixup
patching script interpreter paths in /nix/store/z6pn7zf1qjrzi5zfbjklws4bz8nhzl1y-bazel-0.12.0
checking for references to /tmp in /nix/store/z6pn7zf1qjrzi5zfbjklws4bz8nhzl1y-bazel-0.12.0...
/nix/store/z6pn7zf1qjrzi5zfbjklws4bz8nhzl1y-bazel-0.12.0

@zimbatm zimbatm merged commit 9ef306b into NixOS:master May 8, 2018
@zimbatm
Copy link
Member

zimbatm commented May 8, 2018

ping @philandstuff

@philandstuff
Copy link
Contributor

philandstuff commented May 11, 2018 via email

@zimbatm
Copy link
Member

zimbatm commented May 11, 2018

cc @mboes ?

@mboes
Copy link
Contributor

mboes commented May 13, 2018

Would be happy to do so. Could we merge the current patch as-is and I'll add myself as maintainer in a separate PR?

@philandstuff
Copy link
Contributor

@mboes not sure what you mean, as this PR is already merged. But I'm happy for you to raise a PR replacing me as maintainer. Thank you!

@mboes
Copy link
Contributor

mboes commented May 13, 2018

@philandstuff oh hadn't noticed that @zimbatm merged right before pinging you. Will submit new PR shortly (taking the opportunity to switch to 0.13, which has since come out).

@philandstuff
Copy link
Contributor

@mboes there's already a PR for that upgrade: #40205

@mboes mboes mentioned this pull request May 14, 2018
8 tasks
xeji pushed a commit that referenced this pull request Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants