Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpfr update #39578

Merged
merged 2 commits into from Apr 27, 2018
Merged

mpfr update #39578

merged 2 commits into from Apr 27, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 26, 2018 •
edited

Motivation for this change

mpfr was outdated, mpfi needs to be updated for compatibility. Also see #36620.
This is a stdenv change and causes a rebuild of everything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau changed the title ggMpfr update mpfr update Apr 26, 2018
@timokau timokau mentioned this pull request Apr 26, 2018
Closed
@timokau timokau changed the title mpfr update [WIP] mpfr update Apr 26, 2018
@timokau timokau changed the title [WIP] mpfr update mpfr update Apr 26, 2018
@timokau
Copy link
Member Author

timokau commented Apr 27, 2018

I rebuild sage from the ground up with this patch applied, rebuilding ~650 packages without problem. Together with the fact that arch already switched, I think its reasonably safe to merge this into staging and see what happens.

@7c6f434c 7c6f434c merged commit 6d95d1d into NixOS:staging Apr 27, 2018
@timokau timokau deleted the mpfr-update branch April 27, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @7c6f434c @GrahamcOfBorg