Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamviewer: 12.0.90041 -> 13.1.3026 #39579

Merged
merged 1 commit into from Apr 27, 2018
Merged

teamviewer: 12.0.90041 -> 13.1.3026 #39579

merged 1 commit into from Apr 27, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Apr 26, 2018

Motivation for this change

Close #39070. Update and move to qt5. Dropped i686 support because it didn't build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
teamviewer 12.0.90041 -> 13.1.3026
9badee0 
bump, move to qt5, drop i686 support
@Mic92
Copy link
Member

Mic92 commented Apr 27, 2018

Also this is a major upgrade I think it should be backported because the old version is incompatible to other clients, right?

@Mic92 Mic92 merged commit fd29514 into NixOS:master Apr 27, 2018
@xeji
Copy link
Contributor Author

xeji commented Apr 27, 2018

Good point. It does build and start on 18.03, so I think it can be backported as is.

@xeji xeji deleted the teamviewer branch April 27, 2018 08:02
@danbst
Copy link
Contributor

danbst commented Jul 14, 2018

I get Segmentation Fault.

$ nix run -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/9badee01c1540629f6841177d0067682fbc7f437.tar.gz nixpkgs.teamviewer -c teamviewer
Init...
CheckCPU: SSE2 support: yes
Checking setup...
Launching TeamViewer ...
Launching TeamViewer GUI ...
Segmentation fault

$ teamviewer --version

 TeamViewer                           13.1.3026  (DEB)

Previous version at least launches

$ nix run -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/6e55d835762cef7015ee703e6d5edb1f188467.tar.gz nixpkgs.teamviewer -c teamviewer

@xeji
Copy link
Contributor Author

xeji commented Jul 15, 2018

There are known issues in nixpkgs with mixing muitiple versions of qt5 on your system (for example #17448 and issues referenced from there). In particular, this can happen when you try to use a qt5 app from master/unstable (qt 5.11.1) on a NixOS 18.03 system (qt 5.10). It should work if your system is fully built on master or unstable.

Could that be the issue you experience?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @Mic92 @danbst @GrahamcOfBorg