Mixxx: 2.0.0 -> 2.1.0 #39106
Mixxx: 2.0.0 -> 2.1.0 #39106
Conversation
|
Since qt4 is deprecated, please incorporate the mixxx changes from #33239 that move things to qt5. |
|
The mixxx documentation says that building with qt5 is experimental. |
|
2.1 is the last version with support for qt4 ref mixxxdj/mixxx#1526 (comment) so things are moving towards qt5. That being said, there seems to be an issue with qt 5.10. I think you make a valid point - I'll update my PR to make qt5 optional so people can at least start trying out. |
| @@ -1,16 +1,19 @@ | |||
| # set VAMP_PATH ? | |||
| # plugins availible on sourceforge and http://www.vamp-plugins.org/download.html (various licenses) | |||
|
|
|||
| { stdenv, fetchurl, pkgconfig, libsndfile }: | |||
| { stdenv, fetchFromGitHub, pkgconfig, libsndfile }: | |||
|
|
|||
| rec { | |||
|
|
|||
| vampSDK = stdenv.mkDerivation { | |||
There was a problem hiding this comment.
If you make this vampSDK = stdenv.mkDerivation rec { you can use version properly below.
There was a problem hiding this comment.
I'm sorry, I don't get what you are saying here.
There was a problem hiding this comment.
I have just pushed a commit to your branch.
| vampSDK = stdenv.mkDerivation { | ||
| name = "vamp-sdk-2.5"; | ||
| vampSDK = stdenv.mkDerivation rec { | ||
| name = "vamp-sdk-${version}"; |
There was a problem hiding this comment.
Eval fails because version is undefined here (see ofborg checks).
|
No longer relevant. |
Motivation for this change
Version 2.0.0 doesn't build on nixos-unstable, this does.
Needs #39105
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)