libstore: Verify and repair path metadata on `nix-store --verify --check-contents' #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck-contents` Currently, if you somehow end up with store paths that contain an invalid permission (i.e. not 444 or 555) or mtime (i.e. not 1), figuring out the problem and fixing it is quite difficult. (See e.g. NixOS/nixpkgs#32242). Fortunately, this is quite simple to fix by calling canonicalisePathMetaData() in --check-contents handling, just need to add some prints to show when problems are getting repaired. Fixes NixOS#1760.
|
that's really cool. I have no idea why but it sometimes happens with iproute package that files have wrong permissions. My first attempt at nix-store --delete nuked my config, As a fallback I now mounted the store as rw and change the permissions manually whenever I need to. This PR would obviosuly be better. |
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you somehow end up with store paths that contain an
invalid permission (i.e. not 444 or 555) or mtime (i.e. not 1),
figuring out the problem and fixing it is quite difficult. (See e.g.
NixOS/nixpkgs#32242).
Fortunately, this is quite simple to fix by calling
canonicalisePathMetaData() in --check-contents handling, just need to
add some prints to show when problems are getting repaired.