Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: use toPythonApplication #40831

Merged
merged 1 commit into from May 22, 2018
Merged

youtube-dl: use toPythonApplication #40831

merged 1 commit into from May 22, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented May 20, 2018 •
edited

Motivation for this change

pythonPackages.youtube-dl should not use buildPythonApplication

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @FRidh

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.5.9
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/brh44ixrib5w8p96mwx3cwz59ig4f9cs-python2.7-youtube-dl-2018.05.09
gzipping man pages under /nix/store/brh44ixrib5w8p96mwx3cwz59ig4f9cs-python2.7-youtube-dl-2018.05.09/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/brh44ixrib5w8p96mwx3cwz59ig4f9cs-python2.7-youtube-dl-2018.05.09/lib  /nix/store/brh44ixrib5w8p96mwx3cwz59ig4f9cs-python2.7-youtube-dl-2018.05.09/bin
patching script interpreter paths in /nix/store/brh44ixrib5w8p96mwx3cwz59ig4f9cs-python2.7-youtube-dl-2018.05.09
checking for references to /build in /nix/store/brh44ixrib5w8p96mwx3cwz59ig4f9cs-python2.7-youtube-dl-2018.05.09...
wrapping `/nix/store/brh44ixrib5w8p96mwx3cwz59ig4f9cs-python2.7-youtube-dl-2018.05.09/bin/youtube-dl'...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.5.9
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hbws7g2ffayby9siad2ksavbpabqrapf-python2.7-youtube-dl-2018.05.09
gzipping man pages under /nix/store/hbws7g2ffayby9siad2ksavbpabqrapf-python2.7-youtube-dl-2018.05.09/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hbws7g2ffayby9siad2ksavbpabqrapf-python2.7-youtube-dl-2018.05.09/lib  /nix/store/hbws7g2ffayby9siad2ksavbpabqrapf-python2.7-youtube-dl-2018.05.09/bin
patching script interpreter paths in /nix/store/hbws7g2ffayby9siad2ksavbpabqrapf-python2.7-youtube-dl-2018.05.09
checking for references to /build in /nix/store/hbws7g2ffayby9siad2ksavbpabqrapf-python2.7-youtube-dl-2018.05.09...
wrapping `/nix/store/hbws7g2ffayby9siad2ksavbpabqrapf-python2.7-youtube-dl-2018.05.09/bin/youtube-dl'...

@veprbl
Copy link
Member

veprbl commented May 21, 2018 •
edited

So you just drop ytdl support in bomi and mpv. Why?
Edit: Ah, you are not. Sorry

FRidh
FRidh approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look a bit weird that the package is called from within python-packages.nix which isn't exactly how it should be, but I guess this is an edge case.

@dotlambda
Copy link
Member Author

It does look a bit weird that the package is called from within python-packages.nix

I can move the expression to pkgs/development/python-modules if you want.

@dotlambda dotlambda merged commit 57d591e into NixOS:master May 22, 2018
@dotlambda dotlambda deleted the youtube-dl-application branch May 22, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @veprbl @FRidh