Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwupd: 1.0.5 -> 1.0.7 #40872

Closed
wants to merge 1 commit into from
Closed

fwupd: 1.0.5 -> 1.0.7 #40872

wants to merge 1 commit into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Regular upgrade.

Apologies for the ugly workaround for finding /etc/os-release when building in a sandbox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fwupd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/c0kv6l9y27zbbjm5ci4r1fqwnnvmk1w2-fwupd-1.0.7-man
gzipping man pages under /nix/store/c0kv6l9y27zbbjm5ci4r1fqwnnvmk1w2-fwupd-1.0.7-man/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/c0kv6l9y27zbbjm5ci4r1fqwnnvmk1w2-fwupd-1.0.7-man
checking for references to /build in /nix/store/c0kv6l9y27zbbjm5ci4r1fqwnnvmk1w2-fwupd-1.0.7-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/0xg77k6wq5gr9smn58b37ds3l46dab1v-fwupd-1.0.7-installedTests
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0xg77k6wq5gr9smn58b37ds3l46dab1v-fwupd-1.0.7-installedTests
checking for references to /build in /nix/store/0xg77k6wq5gr9smn58b37ds3l46dab1v-fwupd-1.0.7-installedTests...
/nix/store/9rjrjqvpkwqr6nyr2msvh7f1xjqcpwna-fwupd-1.0.7

@jtojnar
Copy link
Contributor

jtojnar commented May 21, 2018

See also #39792

@peterhoeg
Copy link
Member Author

I have no idea why I didn't see this...

@pSub
Copy link
Member

pSub commented May 30, 2018

Can this one be closed as a duplicate of #39792 or is this PR in a better state than #39792?

@peterhoeg
Copy link
Member Author

The tests work in this PR because we ugly-patch the path to /etc/os-release which isn't available in the sandbox and I am using this on my side. Since the other PR came first, it really should be the one going in so I'll close this.

@peterhoeg peterhoeg closed this May 31, 2018
@pSub
Copy link
Member

pSub commented May 31, 2018

Thanks!

@jtojnar jtojnar mentioned this pull request Jun 2, 2018
Merged
8 tasks
@peterhoeg peterhoeg deleted the u/fwupd branch April 4, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @GrahamcOfBorg @jtojnar @pSub