Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6b438a5771f1
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fd8bd42d1bf3
Choose a head ref

Commits on May 12, 2018

  1. xquartz: fix build

    Things done:
    
    - use libGLU instead of mesa for darwin support
    - move patches from local to github url
    - fixup xquartz install
    
    There may still be some issues at runtime. PRs welcome!
    
    Fixes #40196
    
    (cherry picked from commit c839771)
    matthewbauer authored and vcunat committed May 12, 2018
    Copy the full SHA
    7e14bdc View commit details

Commits on May 15, 2018

  1. nixos: systemd.services.*.environment: fix type

    (cherry picked from commit fb2a8d6)
    oxij authored and LnL7 committed May 15, 2018
    Copy the full SHA
    8887925 View commit details
  2. Copy the full SHA
    81a48c8 View commit details
  3. discord: 0.0.4 -> 0.0.5

    (cherry picked from commit d72b870)
    lightdiscord authored and Cray Elliott committed May 15, 2018
    Copy the full SHA
    6f7f687 View commit details
  4. nix-review: init at 0.1.0

    (cherry picked from commit 96b106b)
    Mic92 committed May 15, 2018
    Copy the full SHA
    303cb2e View commit details
  5. nix-review: 0.1.0 -> 0.1.2

    (cherry picked from commit 6bd669f)
    Mic92 committed May 15, 2018
    Copy the full SHA
    bbb46b1 View commit details
  6. nix-review: 0.1.2 -> 0.2.0

    (cherry picked from commit caa4530)
    Mic92 committed May 15, 2018
    Copy the full SHA
    380d7d0 View commit details
  7. Add bash to jira PATH: required by health checks.

    (cherry picked from commit 15e4447)
    jbgi authored and Mic92 committed May 15, 2018
    Copy the full SHA
    e11b295 View commit details
  8. nixos/tests/kafka: fix and refactor tests

    - refactor into single file for all versions
    - improve timing, prevent non-deterministic failures
    - fix tests for i686-linux
    
    (cherry picked from commit 13f83ba)
    xeji committed May 15, 2018
    Copy the full SHA
    d92331c View commit details

Commits on May 16, 2018

  1. Merge pull request #40561 from ElvishJerricco/backport-18.03-fix-over…

    …riding-all-cabal-hashes
    
    backport: haskellPackages: Fix overriding all-cabal-hashes
    matthewbauer authored May 16, 2018
    Copy the full SHA
    56f199b View commit details
  2. linux: 4.4.131 -> 4.4.132

    (cherry picked from commit 56beb9b)
    NeQuissimus committed May 16, 2018
    Copy the full SHA
    30016b3 View commit details
  3. linux: 4.9.99 -> 4.9.100

    (cherry picked from commit b8aa951)
    NeQuissimus committed May 16, 2018
    Copy the full SHA
    35620c3 View commit details
  4. linux: 4.14.40 -> 4.14.41

    (cherry picked from commit 8d68eca)
    NeQuissimus committed May 16, 2018
    Copy the full SHA
    e9ba8d9 View commit details
  5. dunst: add wrapper to find librsvg (#40050)

    (cherry picked from commit e3b3eac and
    resolved merge conflict)
    rycee authored and xeji committed May 16, 2018
    Copy the full SHA
    ee951c3 View commit details
  6. nixos/tests/mesos: wait for all services and ports

    to be available before sending requests.
    Avoids non-deterministic test failure.
    
    (cherry picked from commit 0d2a4ed)
    xeji committed May 16, 2018
    Copy the full SHA
    345f14e View commit details
  7. nixos/mesos-slave: start after docker

    If docker is enabled, start mesos-slave.service after docker.service
    to avoid a race condition that could result in mesos-slave to fail
    with "Failed to create docker: Timed out getting docker version"
    
    (cherry picked from commit ec00b6f)
    xeji committed May 16, 2018
    Copy the full SHA
    ec1ee66 View commit details

Commits on May 17, 2018

  1. linux-copperhead: 4.14.39.a -> 4.14.41.a

    (cherry picked from commit b577dc3)
    NeQuissimus committed May 17, 2018
    Copy the full SHA
    ab8b927 View commit details
  2. linux-copperhead: 4.16.7.a -> 4.16.9.a

    (cherry picked from commit 1006c8c)
    NeQuissimus committed May 17, 2018
    Copy the full SHA
    14f84df View commit details
  3. kafka: 1.0.0 -> 1.0.1

    (cherry picked from commit c65686c)
    NeQuissimus committed May 17, 2018
    Copy the full SHA
    eab067f View commit details
  4. minio: 2018-02-09T22-40-05Z -> 2018-03-19T19-22-06Z

    (cherry picked from commit a76a8cc)
    Signed-off-by: Domen Kožar <domen@dev.si>
    bachp authored and domenkozar committed May 17, 2018
    Copy the full SHA
    aa15659 View commit details
  5. minio: 2018-03-19T19-22-06Z -> 2018-03-30T00-38-44Z

    (cherry picked from commit 2dc8520)
    Signed-off-by: Domen Kožar <domen@dev.si>
    adisbladis authored and domenkozar committed May 17, 2018
    Copy the full SHA
    3931bf8 View commit details
  6. minio: 2018-03-30T00-38-44Z -> 2018-05-11T00-29-24Z

    (cherry picked from commit 3518211)
    Signed-off-by: Domen Kožar <domen@dev.si>
    bachp authored and domenkozar committed May 17, 2018
    Copy the full SHA
    745075d View commit details
  7. minio: use go 1.10

    domenkozar committed May 17, 2018
    Copy the full SHA
    03b44ad View commit details
  8. knot-dns: 2.6.5 -> 2.6.7

    https://lists.nic.cz/pipermail/knot-dns-users/2018-May/001356.html
    Some of the fixed bugs could be exploited to crash knot-resolver
    if running in --verbose mode.
    
    (cherry picked from commit 24f61ca)
    vcunat committed May 17, 2018
    Copy the full SHA
    3de03b6 View commit details
  9. ntp: 4.2.8p10 -> 4.2.8p11 (#40661)

    Contains several CVE fixes.
    
    (cherry picked from commit 81a0a3b)
    r-ryantm authored and xeji committed May 17, 2018
    Copy the full SHA
    78d4a1e View commit details

Commits on May 18, 2018

  1. chromium: 66.0.3359.139 -> 66.0.3359.170

    Update includes 4 security fixes, including one critical (see [0]):
    
    * [835887] Critical: Chain leading to sandbox escape. Reported by Anonymous on 2018-04-23:
    * [836858] High CVE-2018-6121: Privilege Escalation in extensions.
    * [836141] High CVE-2018-6122: Type confusion in V8.
    * [$5000][833721] High CVE-2018-6120: Heap buffer overflow in PDFium.  Reported by Zhou Aiting(@zhouat1) of Qihoo 360 Vulcan Team on 2018-04-17
    
    [0] https://chromereleases.googleblog.com/2018/05/stable-channel-update-for-desktop.html
    
    PS: Didn't build Beta and Dev, verified only Stable for now
    
    cc @bendlas @aszlig
    
    (cherry picked from commit 1837026)
    YorikSar committed May 18, 2018
    Copy the full SHA
    c6a5b16 View commit details
  2. chromium: 66.0.3359.170 -> 66.0.3359.181

    (cherry picked from commit 2729875)
    YorikSar committed May 18, 2018
    Copy the full SHA
    fcea258 View commit details

Commits on May 19, 2018

  1. firefox-bin: 60.0 -> 60.0.1

    (cherry picked from commit f4152ea)
    taku0 committed May 19, 2018
    Copy the full SHA
    6a451a5 View commit details
  2. firefox: 60.0 -> 60.0.1

    (cherry picked from commit f2b3cdd)
    taku0 committed May 19, 2018
    Copy the full SHA
    11e2968 View commit details
  3. firefox-esr: 60.0esr -> 60.0.1esr

    (cherry picked from commit 2f076b4)
    taku0 committed May 19, 2018
    Copy the full SHA
    69de43c View commit details
  4. thunderbird-bin: 52.7.0 -> 52.8.0

    (cherry picked from commit 0544c38)
    taku0 authored and Robert Schütz committed May 19, 2018
    Copy the full SHA
    db0720e View commit details
  5. thunderbird: 52.7.0 -> 52.8.0

    (cherry picked from commit 6099ad3)
    taku0 authored and Robert Schütz committed May 19, 2018
    Copy the full SHA
    ee80654 View commit details
  6. Copy the full SHA
    6d9aa78 View commit details
  7. Merge #40407: xquartz: fix build

    vcunat committed May 19, 2018
    Copy the full SHA
    2385549 View commit details

Commits on May 20, 2018

  1. nixos/cjdns: fix service for i686 (#40740)

    service failed to start because of MemoryDenyWriteExecute = true,
    which seems not to work on i686
    
    (cherry picked from commit f4ec18a)
    xeji committed May 20, 2018
    Copy the full SHA
    7dac244 View commit details
  2. Merge #37636: wrapFirefox: update icon location

    (cherry picked from commit 6ca5577)
    Fixes #38536.
    Thomas Tuegel authored and vcunat committed May 20, 2018
    Copy the full SHA
    eb5a7a5 View commit details

Commits on May 21, 2018

  1. linux: 4.9.100 -> 4.9.101

    (cherry picked from commit 61fe3e86f65ec74b1710d1e63710c08250e4acc4)
    NeQuissimus committed May 21, 2018
    Copy the full SHA
    b39f010 View commit details
  2. linux: 4.14.41 -> 4.14.42

    (cherry picked from commit 33632bc43e26552f3dc1e33726e18cf0d7301b0f)
    NeQuissimus committed May 21, 2018
    Copy the full SHA
    6505576 View commit details
  3. Copy the full SHA
    fd8bd42 View commit details
Showing with 824 additions and 1,681 deletions.
  1. +1 −1 nixos/modules/services/misc/mesos-slave.nix
  2. +2 −1 nixos/modules/services/networking/cjdns.nix
  3. +1 −1 nixos/modules/services/web-apps/atlassian/jira.nix
  4. +1 −1 nixos/modules/system/boot/systemd-unit-options.nix
  5. +1 −4 nixos/release.nix
  6. +68 −0 nixos/tests/kafka.nix
  7. +0 −48 nixos/tests/kafka_0_10.nix
  8. +0 −48 nixos/tests/kafka_0_11.nix
  9. +0 −48 nixos/tests/kafka_0_9.nix
  10. +0 −48 nixos/tests/kafka_1_0.nix
  11. +3 −1 nixos/tests/mesos.nix
  12. +7 −2 pkgs/applications/misc/dunst/default.nix
  13. +9 −9 pkgs/applications/networking/browsers/chromium/upstream-info.nix
  14. +393 −393 pkgs/applications/networking/browsers/firefox-bin/release_sources.nix
  15. +6 −6 pkgs/applications/networking/browsers/firefox/packages.nix
  16. +5 −3 pkgs/applications/networking/browsers/firefox/wrapper.nix
  17. +2 −2 pkgs/applications/networking/instant-messengers/discord/default.nix
  18. +237 −237 pkgs/applications/networking/mailreaders/thunderbird-bin/release_sources.nix
  19. +2 −2 pkgs/applications/networking/mailreaders/thunderbird/default.nix
  20. +1 −1 pkgs/development/haskell-modules/default.nix
  21. +2 −2 pkgs/os-specific/linux/kernel/linux-4.14.nix
  22. +2 −2 pkgs/os-specific/linux/kernel/linux-4.4.nix
  23. +2 −2 pkgs/os-specific/linux/kernel/linux-4.9.nix
  24. +2 −2 pkgs/os-specific/linux/kernel/linux-copperhead-lts.nix
  25. +2 −2 pkgs/os-specific/linux/kernel/linux-copperhead-stable.nix
  26. +2 −2 pkgs/servers/apache-kafka/default.nix
  27. +2 −2 pkgs/servers/dns/knot-dns/default.nix
  28. +4 −4 pkgs/servers/minio/default.nix
  29. +0 −41 pkgs/servers/x11/xorg/darwin/0002-sdksyms.sh-Use-CPPFLAGS-not-CFLAGS.patch
  30. +0 −297 pkgs/servers/x11/xorg/darwin/0004-Use-old-miTrapezoids-and-miTriangles-routines.patch
  31. +0 −243 pkgs/servers/x11/xorg/darwin/0006-fb-Revert-fb-changes-that-broke-XQuartz.patch
  32. +0 −118 pkgs/servers/x11/xorg/darwin/bundle_main.patch
  33. +0 −12 pkgs/servers/x11/xorg/darwin/private-extern.patch
  34. +0 −80 pkgs/servers/x11/xorg/darwin/stub.patch
  35. +26 −10 pkgs/servers/x11/xorg/overrides.nix
  36. +1 −3 pkgs/servers/x11/xquartz/system-fonts.nix
  37. +2 −2 pkgs/tools/networking/ntp/default.nix
  38. +31 −0 pkgs/tools/package-management/nix-review/default.nix
  39. +7 −1 pkgs/top-level/all-packages.nix
2 changes: 1 addition & 1 deletion nixos/modules/services/misc/mesos-slave.nix
Original file line number Diff line number Diff line change
@@ -187,7 +187,7 @@ in {
systemd.services.mesos-slave = {
description = "Mesos Slave";
wantedBy = [ "multi-user.target" ];
after = [ "network.target" ];
after = [ "network.target" ] ++ optionals cfg.withDocker [ "docker.service" ] ;
path = [ pkgs.stdenv.shellPackage ];
serviceConfig = {
ExecStart = ''
3 changes: 2 additions & 1 deletion nixos/modules/services/networking/cjdns.nix
Original file line number Diff line number Diff line change
@@ -260,7 +260,8 @@ in
RestartSec = 1;
CapabilityBoundingSet = "CAP_NET_ADMIN CAP_NET_RAW CAP_SETUID";
ProtectSystem = true;
MemoryDenyWriteExecute = true;
# Doesn't work on i686, causing service to fail
MemoryDenyWriteExecute = !pkgs.stdenv.isi686;
ProtectHome = true;
PrivateTmp = true;
};
2 changes: 1 addition & 1 deletion nixos/modules/services/web-apps/atlassian/jira.nix
Original file line number Diff line number Diff line change
@@ -155,7 +155,7 @@ in
requires = [ "postgresql.service" ];
after = [ "postgresql.service" ];

path = [ cfg.jrePackage ];
path = [ cfg.jrePackage pkgs.bash ];

environment = {
JIRA_USER = cfg.user;
2 changes: 1 addition & 1 deletion nixos/modules/system/boot/systemd-unit-options.nix
Original file line number Diff line number Diff line change
@@ -217,7 +217,7 @@ in rec {

environment = mkOption {
default = {};
type = with types; attrsOf (nullOr (either str package));
type = with types; attrsOf (nullOr (either str (either path package)));
example = { PATH = "/foo/bar/bin"; LANG = "nl_NL.UTF-8"; };
description = "Environment variables passed to the service's processes.";
};
5 changes: 1 addition & 4 deletions nixos/release.nix
Original file line number Diff line number Diff line change
@@ -304,10 +304,7 @@ in rec {
tests.plotinus = callTest tests/plotinus.nix {};
tests.keymap = callSubTests tests/keymap.nix {};
tests.initrdNetwork = callTest tests/initrd-network.nix {};
tests.kafka_0_9 = callTest tests/kafka_0_9.nix {};
tests.kafka_0_10 = callTest tests/kafka_0_10.nix {};
tests.kafka_0_11 = callTest tests/kafka_0_11.nix {};
tests.kafka_1_0 = callTest tests/kafka_1_0.nix {};
tests.kafka = callSubTests tests/kafka.nix {};
tests.kernel-copperhead = callTest tests/kernel-copperhead.nix {};
tests.kernel-latest = callTest tests/kernel-latest.nix {};
tests.kernel-lts = callTest tests/kernel-lts.nix {};
68 changes: 68 additions & 0 deletions nixos/tests/kafka.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{ system ? builtins.currentSystem }:
with import ../lib/testing.nix { inherit system; };
with pkgs.lib;

let
makeKafkaTest = name: kafkaPackage: (makeTest {
inherit name;
meta = with pkgs.stdenv.lib.maintainers; {
maintainers = [ nequissimus ];
};

nodes = {
zookeeper1 = { config, ... }: {
services.zookeeper = {
enable = true;
};

networking.firewall.allowedTCPPorts = [ 2181 ];
virtualisation.memorySize = 1024;
};
kafka = { config, ... }: {
services.apache-kafka = {
enable = true;
extraProperties = ''
offsets.topic.replication.factor = 1
zookeeper.session.timeout.ms = 600000
'';
package = kafkaPackage;
zookeeper = "zookeeper1:2181";
# These are the default options, but UseCompressedOops doesn't work with 32bit JVM
jvmOptions = [
"-server" "-Xmx1G" "-Xms1G" "-XX:+UseParNewGC" "-XX:+UseConcMarkSweepGC" "-XX:+CMSClassUnloadingEnabled"
"-XX:+CMSScavengeBeforeRemark" "-XX:+DisableExplicitGC" "-Djava.awt.headless=true" "-Djava.net.preferIPv4Stack=true"
] ++ optionals (! pkgs.stdenv.isi686 ) [ "-XX:+UseCompressedOops" ];
};

networking.firewall.allowedTCPPorts = [ 9092 ];
# i686 tests: qemu-system-i386 can simulate max 2047MB RAM (not 2048)
virtualisation.memorySize = 2047;
};
};

testScript = ''
startAll;
$zookeeper1->waitForUnit("default.target");
$zookeeper1->waitForUnit("zookeeper.service");
$zookeeper1->waitForOpenPort(2181);
$kafka->waitForUnit("default.target");
$kafka->waitForUnit("apache-kafka.service");
$kafka->waitForOpenPort(9092);
$kafka->waitUntilSucceeds("${kafkaPackage}/bin/kafka-topics.sh --create --zookeeper zookeeper1:2181 --partitions 1 --replication-factor 1 --topic testtopic");
$kafka->mustSucceed("echo 'test 1' | ${kafkaPackage}/bin/kafka-console-producer.sh --broker-list localhost:9092 --topic testtopic");
'' + (if name == "kafka_0_9" then ''
$kafka->mustSucceed("${kafkaPackage}/bin/kafka-console-consumer.sh --zookeeper zookeeper1:2181 --topic testtopic --from-beginning --max-messages 1 | grep 'test 1'");
'' else ''
$kafka->mustSucceed("${kafkaPackage}/bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 --topic testtopic --from-beginning --max-messages 1 | grep 'test 1'");
'');
});

in with pkgs; {
kafka_0_9 = makeKafkaTest "kafka_0_9" apacheKafka_0_9;
kafka_0_10 = makeKafkaTest "kafka_0_10" apacheKafka_0_10;
kafka_0_11 = makeKafkaTest "kafka_0_11" apacheKafka_0_11;
kafka_1_0 = makeKafkaTest "kafka_1_0" apacheKafka_1_0;
}
48 changes: 0 additions & 48 deletions nixos/tests/kafka_0_10.nix

This file was deleted.

48 changes: 0 additions & 48 deletions nixos/tests/kafka_0_11.nix

This file was deleted.

48 changes: 0 additions & 48 deletions nixos/tests/kafka_0_9.nix

This file was deleted.

48 changes: 0 additions & 48 deletions nixos/tests/kafka_1_0.nix

This file was deleted.

4 changes: 3 additions & 1 deletion nixos/tests/mesos.nix
Original file line number Diff line number Diff line change
@@ -66,9 +66,11 @@ import ./make-test.nix ({ pkgs, ...} : rec {
testScript =
''
startAll;
$master->waitForUnit("zookeeper.service");
$master->waitForUnit("mesos-master.service");
$slave->waitForUnit("docker.service");
$slave->waitForUnit("mesos-slave.service");
$master->waitForOpenPort(2181);
$master->waitForOpenPort(5050);
$slave->waitForOpenPort(5051);
9 changes: 7 additions & 2 deletions pkgs/applications/misc/dunst/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchFromGitHub, fetchpatch
{ stdenv, fetchFromGitHub, fetchpatch, makeWrapper
, pkgconfig, which, perl, libXrandr
, cairo, dbus, systemd, gdk_pixbuf, glib, libX11, libXScrnSaver
, libXinerama, libnotify, libxdg_basedir, pango, xproto, librsvg
@@ -15,7 +15,7 @@ stdenv.mkDerivation rec {
sha256 = "0i518v2z9fklzl5w60gkwwmg30yz3bd0k4rxjrxjabx73pvxm1mz";
};

nativeBuildInputs = [ perl pkgconfig which systemd ];
nativeBuildInputs = [ perl pkgconfig which systemd makeWrapper ];

buildInputs = [
cairo dbus gdk_pixbuf glib libX11 libXScrnSaver
@@ -31,6 +31,11 @@ stdenv.mkDerivation rec {
"SERVICEDIR_SYSTEMD=$(out)/lib/systemd/user"
];

postInstall = ''
wrapProgram $out/bin/dunst \
--set GDK_PIXBUF_MODULE_FILE "$GDK_PIXBUF_MODULE_FILE"
'';

meta = with stdenv.lib; {
description = "Lightweight and customizable notification daemon";
homepage = https://dunst-project.org/;
18 changes: 9 additions & 9 deletions pkgs/applications/networking/browsers/chromium/upstream-info.nix
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
# This file is autogenerated from update.sh in the same directory.
{
beta = {
sha256 = "136gx9qqbzfzaf19k0gxb8n4ypd4ycyr83i9v68nqdvy2k26vf4n";
sha256bin64 = "0w628afj5k4xygizlznwxkljgc1prxqc3lanaz6gdmyrl7gk1s7n";
version = "67.0.3396.18";
sha256 = "169lxj6rhpqcnrg3n2api82975hkifz6wmks1bh04jkxw0z2vkny";
sha256bin64 = "1hd4s35yhi2xidy3xncp66p03cv715bzbf3gcv5dl0d1h3nmhhdf";
version = "67.0.3396.40";
};
dev = {
sha256 = "1yspf0n385ail9qxsmax58mfk5yi473ygsraqs83q30pfgxc5z2f";
sha256bin64 = "1gi1xpnjwkg7sxv94ksv6fiymw13rxdq2hyvza8b9famvfcaz07j";
version = "68.0.3409.2";
sha256 = "0j4vcfbdj8cvdsmnb6pz0k71w559rm3ka1yyv0yfq7f756hinpvp";
sha256bin64 = "1qqhyjdd227psvr904w3d3lq47bfwmpk6f7sam2gp4j0wxn23w8w";
version = "68.0.3423.2";
};
stable = {
sha256 = "1ck4wbi28702p1lfs4sz894ysbgm7fj79wrqj8srsy65z2ssaxdy";
sha256bin64 = "1vgrgay3h0961vj96ql2p0pb16gzfr48r4hk25rxdqbflnz7njz0";
version = "66.0.3359.139";
sha256 = "06g9m7lxm9g63dcci25dqiglyjxjfy7v05vjhdda4rdk84vngrip";
sha256bin64 = "105ds6r6awzhf5sq3nf43b6zb84lb4qbhjnfk3fnxfqvskq3b6r2";
version = "66.0.3359.181";
};
}
Loading