nixos/ipfs: Add option to disable local port scanning for ipfs daemon #40879
Conversation
There was a problem hiding this comment.
I suggest this phrasing for the first paragraph:
Whether to enable local discovery for the ipfs daemon. This will allow ipfs to scan ports on your local network. Some hosting services will ban you if you do this.
For the second paragraph, can you expand on what this means? It's not clear to me whether this means that I'd have to manually take action on some of the files in the dataDir.
|
(Essentially, the second paragraph should explain what the user should do in order to change the option after initializing ipfs, at the very least.) |
|
@srhb thanks for your feedback. i'll change the phrasing, because I also like yours better. Also, I found a way to get around the issue mentioned in the second paragraph. |
It is no longer required to change the config your ipfs repo manually if you change localDiscovery option in nixos configuration after ipfs repository initialization.
|
Great, this is a much better solution. :) |
Motivation for this change
Hi, some hosting services really don't like port scanning. Unfortunately ipfs does this by default. This patch introduces a new option that disables this behavior.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)