Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: 0.12.0 -> 0.13.0 #40205

Closed
wants to merge 2 commits into from
Closed

bazel: 0.12.0 -> 0.13.0 #40205

wants to merge 2 commits into from

Conversation

rdnetto4
Copy link
Contributor

@rdnetto4 rdnetto4 commented May 9, 2018

Motivation for this change

This PR bumps the Bazel package to the recently released 0.13.0.

Things done

Built Nix package under Sabayon Linux and used it to compile a Bazel project.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented May 9, 2018

Thanks. This needs testing of dependents as version bumps of Bazel typically break things.

@rdnetto4 rdnetto4 requested a review from FRidh as a code owner May 10, 2018 06:50
@rdnetto4
Copy link
Contributor Author

Needed to bump tensorflow to get it to compile with the new Bazel version, still waiting to see if anything else fails.

@FRidh
Copy link
Member

FRidh commented May 13, 2018

cc maintainers @abbradar @jyp

@xeji xeji mentioned this pull request May 13, 2018
8 tasks
@uri-canva
Copy link
Contributor

I get this when I try to build this on NixOS:

ERROR: /tmp/nix-build-bazel-0.13.0.drv-0/third_party/grpc/BUILD:51:1: Creating runfiles tree bazel-out/host/bin/third_party/grpc/cpp_plugin.runfiles [for host] failed (Exit 127): build-runfiles failed: error executing command
  (cd /tmp/bazel_hLCMGkTp/out/execroot/io_bazel && \
  exec env - \
  _bin/build-runfiles bazel-out/host/bin/third_party/grpc/cpp_plugin.runfiles_manifest bazel-out/host/bin/third_party/grpc/cpp_plugin.runfiles)
[2 / 6] //third_party/grpc:cpp_plugin; 0s local
/tmp/bazel_hLCMGkTp/out/execroot/io_bazel/_bin/build-runfiles: line 2: mkdir: command not found
/tmp/bazel_hLCMGkTp/out/execroot/io_bazel/_bin/build-runfiles: line 3: cp: command not found

See my PR for a different approach to have Bazel find coreutils: #40424.

@philandstuff philandstuff mentioned this pull request May 13, 2018
8 tasks
@rdnetto4
Copy link
Contributor Author

It turns out that bumping Bazel requires us to bump Tensorflow (currently 1.5.0), since the new Bazel no longer tolerates certain warnings. There are two potential versions we could update to (1.7.1 and 1.8.0 - for some reason 1.7.1 was released after 1.8.0), both of which are currently failing to build for different reasons. I'm going to try and get 1.7.1 working as it looks like it might just be missing a dependency, but progress will be slow due to the one hour build time.

I suspect I'm not running into the coreutils problem in #40424 because I'm not under NixOS - will try and get it working for my setup first before trying to merge them.

@uri-canva
Copy link
Contributor

See #40424 (comment) for a fix for building under NixOS.

@mboes mboes mentioned this pull request May 14, 2018
8 tasks
@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

closing this in favor of #40525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants