-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: 0.12.0 -> 0.13.0 #40205
bazel: 0.12.0 -> 0.13.0 #40205
Conversation
Thanks. This needs testing of dependents as version bumps of Bazel typically break things. |
Needed to bump tensorflow to get it to compile with the new Bazel version, still waiting to see if anything else fails. |
I get this when I try to build this on NixOS:
See my PR for a different approach to have Bazel find coreutils: #40424. |
It turns out that bumping Bazel requires us to bump Tensorflow (currently 1.5.0), since the new Bazel no longer tolerates certain warnings. There are two potential versions we could update to (1.7.1 and 1.8.0 - for some reason 1.7.1 was released after 1.8.0), both of which are currently failing to build for different reasons. I'm going to try and get 1.7.1 working as it looks like it might just be missing a dependency, but progress will be slow due to the one hour build time. I suspect I'm not running into the coreutils problem in #40424 because I'm not under NixOS - will try and get it working for my setup first before trying to merge them. |
See #40424 (comment) for a fix for building under NixOS. |
closing this in favor of #40525 |
Motivation for this change
This PR bumps the Bazel package to the recently released 0.13.0.
Things done
Built Nix package under Sabayon Linux and used it to compile a Bazel project.
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)